Date: Thu, 25 Feb 2016 21:36:04 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207487] misc/mc: make libssh optional Message-ID: <bug-207487-13-8YJpKtn4aw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-207487-13@https.bugs.freebsd.org/bugzilla/> References: <bug-207487-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207487 --- Comment #2 from Ben Woods <woodsb02@gmail.com> --- Hi Moritz, thanks for your patch! :) It looks mostly good, but I have 2 minor improvements if that is ok. They a= re both based on the fact that according to the mc project documentation, libs= sh is only required for supporting SFTP as a virtual file system. [1] 1. The options should be named SFTP rather than LIBSSH, and the description should be something along the lines of "Support for SFTP (via libssh)" 2. In addition to setting the libssh dependency, this option should also ca= use the configure script to be called with either --enable-vfs-sftp or --disable-vfs-sftp [2]. The following line should be added below the LIBSSH_LIB_DEPENDS line to achieve this: SFTP_CONFIGURE_ENABLE=3D vfs-sftp Do you think you would be able to resubmit your patch with these changes? Lastly, if you do have any way to test building this port with the new opti= on enabled, and then again with it disabled, it is always good to attach any evidence that it works. Thanks again :) [1] http://www.midnight-commander.org/browser/doc/INSTALL#L23 [2] http://www.midnight-commander.org/browser/doc/INSTALL#L179 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207487-13-8YJpKtn4aw>