From owner-freebsd-current Wed Jan 27 21:45:15 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA16522 for freebsd-current-outgoing; Wed, 27 Jan 1999 21:45:15 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from wall.polstra.com (rtrwan160.accessone.com [206.213.115.74]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA16515 for ; Wed, 27 Jan 1999 21:45:14 -0800 (PST) (envelope-from jdp@polstra.com) Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13]) by wall.polstra.com (8.9.1/8.9.1) with ESMTP id VAA03490; Wed, 27 Jan 1999 21:45:12 -0800 (PST) (envelope-from jdp@polstra.com) Received: (from jdp@localhost) by vashon.polstra.com (8.9.1/8.9.1) id VAA07169; Wed, 27 Jan 1999 21:45:11 -0800 (PST) (envelope-from jdp@polstra.com) Message-ID: X-Mailer: XFMail 1.3 [p0] on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <199901280503.QAA05872@godzilla.zeta.org.au> Date: Wed, 27 Jan 1999 21:45:11 -0800 (PST) Organization: Polstra & Co., Inc. From: John Polstra To: Bruce Evans Subject: Re: btokup() macro in sys/malloc.h Cc: current@FreeBSD.ORG Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 28-Jan-99 Bruce Evans wrote: >>The added parentheses don't make any difference, semantically. This >>change probably wouldn't meet the criteria spelled out in style(9): >> >> Unary operators don't require spaces, binary operators do. Don't use >> parentheses unless they're required for precedence, or the statement is >> really confusing without them. >> >> a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1; >> k = !(l & FLAGS); > > Nah, style(9), not to mention the example of btokup() in Lite1 and Lite2, > requires paretheses here (in btokup(), and probably in the bad example in > style(9), because the expression would be really confusing without them :-). Hear ye, hear ye! Be it here noted and archived for all eternity that on January 27, 1999 Pacific Time, John Polstra was, for one fleeting moment, purer than Bruce! :-) John --- John Polstra jdp@polstra.com John D. Polstra & Co., Inc. Seattle, Washington USA "Nobody ever went broke underestimating the taste of the American public." -- H. L. Mencken To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message