From owner-cvs-all  Thu Mar  7  5:19:41 2002
Delivered-To: cvs-all@freebsd.org
Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153])
	by hub.freebsd.org (Postfix) with ESMTP
	id 67A3E37B404; Thu,  7 Mar 2002 05:19:37 -0800 (PST)
Received: by gw.nectar.cc (Postfix, from userid 1001)
	id D379B36; Thu,  7 Mar 2002 07:19:36 -0600 (CST)
Date: Thu, 7 Mar 2002 07:19:36 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Mike Barcroft <mike@FreeBSD.org>
Cc: David O'Brien <obrien@FreeBSD.org>,
	Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/rwall rwall.c
Message-ID: <20020307131936.GH36653@hellblazer.nectar.cc>
Mail-Followup-To: "Jacques A. Vidrine" <nectar@FreeBSD.org>,
	Mike Barcroft <mike@FreeBSD.org>, David O'Brien <obrien@FreeBSD.org>,
	Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
References: <200203042027.g24KRc978637@freefall.freebsd.org> <20020307030244.B63484@dragon.nuxi.com> <20020307060920.C81803@espresso.q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020307060920.C81803@espresso.q9media.com>
User-Agent: Mutt/1.3.27i
X-Url: http://www.nectar.cc/
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Mar 07, 2002 at 06:09:20AM -0500, Mike Barcroft wrote:
> David O'Brien <obrien@FreeBSD.org> writes:
> > -       (void)snprintf(tmpname, sizeof(tmpname), "%s/wall.XXXXXX", _PATH_TMP);
> > +       snprintf(tmpname, sizeof(tmpname), "%s/wall.XXXXXX", _PATH_TMP);
> >
> > lint(1) does not like our usage of (void)?  Removing it where it already
> > exists goes against the examples in style(9).
> 
> I thought the point of (void) was to quiet lint(1).

I like it especially in the case, as it means ``yes, I _meant_ to ignore
the result'' --- the author of this code is intentionally ignoring
truncation issues.

OTOH, if the author added it just to quiet lint, it is a bit misleading.

Cheers,
-- 
Jacques A. Vidrine <n@nectar.cc>                     http://www.nectar.cc/
NTT/Verio SME           .      FreeBSD UNIX      .        Heimdal Kerberos
jvidrine@verio.net      .   nectar@FreeBSD.org   .           nectar@kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message