From owner-freebsd-current@FreeBSD.ORG  Sat Jul 16 16:30:59 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 97B9116A41C;
	Sat, 16 Jul 2005 16:30:59 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from harmony.village.org (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3CFDE43D48;
	Sat, 16 Jul 2005 16:30:59 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.13.3/8.13.3) with ESMTP id j6GGTkvW030585;
	Sat, 16 Jul 2005 10:29:46 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sat, 16 Jul 2005 10:30:28 -0600 (MDT)
Message-Id: <20050716.103028.04060625.imp@bsdimp.com>
To: nate@root.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <42D82D59.9060605@root.org>
References: <200507121027.14113.jhb@FreeBSD.org>
	<4.3.2.7.2.20050715164008.01f0fdd8@mail.qconline.com>
	<42D82D59.9060605@root.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org, harrycoin@qconline.com
Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x
 acpi and up
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jul 2005 16:30:59 -0000

In message: <42D82D59.9060605@root.org>
            Nate Lawson <nate@root.org> writes:
: Harry Coin wrote:
: > At 02:28 PM 7/15/2005 -0700, Nate Lawson wrote:
: > 
: >> Drivers should not rely on isa_get_logicalid() to determine a boolean 
: >> "is PNP?"
: > 
: > 
: > The architecture manual specifies ISA_PNP_PROBE in non pnp ISA drivers 
: > for that purpose.  As I understand it, John doesn't like the ugly nature 
: > of passing in a null device list for non-pnp ISA drivers.    Hard to 
: > argue with that.
: > 
: > So why not gin up a tiny little boolean kernel function 
: > 'device_is_pnp(dev)) ' that does the right thing for non-pnp isa drivers 
: > - once -,right after wherever ISA_PNP_PROBE is defined in the kernel?
: 
: I don't understand how this is needed.  ACPI devices are always a 
: superset of PNP.  If a probe method is not PNP capable, it should never 
: attach to the ACPI bus.  I think that's what his fix changes, and I 
: think it's sufficient.

Nate's right here.  It isn't needed.  The ISA_PNP_PROBE is for all
devices that have a PNP ID.  Thse includes ISA PnP cards, PNP BIOS
devices and ACPI devices.  So the device_is_pnp() isn't needed at all.

Warner