From owner-freebsd-current@FreeBSD.ORG Tue Oct 19 15:37:44 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8425416A4CE for ; Tue, 19 Oct 2004 15:37:44 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 324AE43D54 for ; Tue, 19 Oct 2004 15:37:44 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 73A5F6520C; Tue, 19 Oct 2004 16:37:43 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 31717-03-68; Tue, 19 Oct 2004 16:37:43 +0100 (BST) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id C2AA3651EE; Tue, 19 Oct 2004 16:37:42 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id D4073615E; Tue, 19 Oct 2004 08:37:36 -0700 (PDT) Date: Tue, 19 Oct 2004 08:37:36 -0700 From: Bruce M Simpson To: Sebastian Schulze Struchtrup Message-ID: <20041019153736.GB86472@dhcp120.icir.org> Mail-Followup-To: Sebastian Schulze Struchtrup , freebsd-current@freebsd.org References: <41750F05.1010704@struchtrup.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fWddYNRDgTk9wQGZ" Content-Disposition: inline In-Reply-To: <41750F05.1010704@struchtrup.com> cc: freebsd-current@freebsd.org Subject: Re: trap: page fault after shutdown (irq23: vr0) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:37:44 -0000 --fWddYNRDgTk9wQGZ Content-Type: multipart/mixed; boundary="Qrgsu6vtpU/OV/zm" Content-Disposition: inline --Qrgsu6vtpU/OV/zm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Oct 19, 2004 at 02:56:37PM +0200, Sebastian Schulze Struchtrup wrot= e: > I have not noticed this before BETA4. I am currently running 5.3 STABLE/R= C1. > The trap occurs in process "irq23: vr0". I am not sure if this is=20 > related to vr0. The code for vr (sys/pci/if_vr.c) has not changed since= =20 This is a duplicate of kern/62889. vr_shutdown() is incorrect and in fact prone to race on SMP. I've committed a fix to current. Patch is attached. MFC request to RELENG_5 and RELENG_5_3 is pending. Regards, BMS --Qrgsu6vtpU/OV/zm Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="if_vr.c.patch" Content-Transfer-Encoding: quoted-printable Index: if_vr.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/sys/pci/if_vr.c,v retrieving revision 1.94 diff -u -p -r1.94 if_vr.c --- if_vr.c 11 Aug 2004 04:30:49 -0000 1.94 +++ if_vr.c 19 Oct 2004 15:22:08 -0000 @@ -1692,7 +1692,5 @@ vr_shutdown(device_t dev) { struct vr_softc *sc =3D device_get_softc(dev); =20 - VR_LOCK(sc); - vr_stop(sc); - VR_UNLOCK(sc); + vr_detach(sc); } --Qrgsu6vtpU/OV/zm-- --fWddYNRDgTk9wQGZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Comment: '' iD8DBQFBdTTAueUpAYYNtTsRAuTiAJ0YYbHgX3lc9FnIZbMc5Axi7HYX0ACdEkdt iMUveDRLXaPIvGF3aDlfpK0= =vdz2 -----END PGP SIGNATURE----- --fWddYNRDgTk9wQGZ--