Date: Mon, 11 Mar 2013 17:47:56 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Joshua Isom <jrisom@gmail.com> Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: Fine, OK, here's my initial AR9380/AR9485 support Message-ID: <CAJ-Vmokwg_KkbZDh9vSiSQYUg7PKLPNjXs-Epf1YouN7Bb9g5g@mail.gmail.com> In-Reply-To: <CAJ-Vmok2ONOJsZK4BuD9J5drUpmjri6mV-dB4N7-9HvuGcVV0Q@mail.gmail.com> References: <513d3ae3.08c2440a.59a6.63b2@mx.google.com> <513DA767.6010208@gmail.com> <CAJ-Vmo=uSeKK1SV3k_nRLDSHShobiyN6ky861b5NDn_U8NxukQ@mail.gmail.com> <513E6AF5.9010304@gmail.com> <CAJ-Vmo=9Kj41=J3m6SapXi0y6t9cF-A=XCX8AWz0qirLnrwX=Q@mail.gmail.com> <513E7924.3060302@gmail.com> <CAJ-VmomWgitUZvxVQbQc6qFu8rOYJVZiZCrVEjQm2fOdp5Sz7w@mail.gmail.com> <CAJ-Vmok2ONOJsZK4BuD9J5drUpmjri6mV-dB4N7-9HvuGcVV0Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 March 2013 17:43, Adrian Chadd <adrian@freebsd.org> wrote: > .. and yeah, that code is wrong. GCC doesn't complain; just change it to: > > if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) && > > to: > > if ((ahp->ah_enterprise_mode & AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) && > > Thanks, this is the first bug that I can file as having come from the > FreeBSD community. :) Please file an issue regarding this problem: https://github.com/qca/qcamain_open_hal_public/issues and feel free to file another issue (this doesn't compile if ATH_DEBUG / AH_DEBUG isn't specified.) I can submit fixes for both of those in the upstream (internal) HAL. Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmokwg_KkbZDh9vSiSQYUg7PKLPNjXs-Epf1YouN7Bb9g5g>