From owner-cvs-src@FreeBSD.ORG Sat Mar 12 17:31:29 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5783C16A4CE; Sat, 12 Mar 2005 17:31:29 +0000 (GMT) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 981B343D53; Sat, 12 Mar 2005 17:31:28 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) j2CHVOSg091644; Sat, 12 Mar 2005 18:31:24 +0100 (CET) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.11/8.12.10/Submit) id j2CHVJ68091643; Sat, 12 Mar 2005 18:31:19 +0100 (CET) (envelope-from marius) Date: Sat, 12 Mar 2005 18:31:19 +0100 From: Marius Strobl To: Scott Long Message-ID: <20050312183119.F55534@newtrinity.zeist.de> References: <200503121706.j2CH63ds065431@repoman.freebsd.org> <423322C6.2070401@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <423322C6.2070401@samsco.org>; from scottl@samsco.org on Sat, Mar 12, 2005 at 10:11:34AM -0700 X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-6; AVE: 6.30.0.5; VDF: 6.30.0.26; host: newtrinity.zeist.de) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/uart uart_cpu_sparc64.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Mar 2005 17:31:29 -0000 On Sat, Mar 12, 2005 at 10:11:34AM -0700, Scott Long wrote: > Marius Strobl wrote: > > marius 2005-03-12 17:06:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/uart uart_cpu_sparc64.c > > Log: > > In uart_cpu_getdev_console() when determinig whether we should use > > a serial console anyway because input-device is set to keyboard and > > output-device is set to screen but no keyboard is plugged in don't > > assume that a device node for the input-device alias exists. While > > this is true for RS232 keyboards (the node of the SCC and UART > > respectively which controls the keyboard doesn't disappear when no > > keyboard is plugged in) this assumption breaks for USB keyboards. > > It's most likely also not true for PS/2 keyboards but OFW doesn't > > reliably switch to a serial console when the potential keyboard is > > a PS/2 one which isn't plugged in so this couldn't be verified > > properly. > > > > Reported by: Will Andrews , obrien > > MFC after: 1 week > > > > Revision Changes Path > > 1.18 +6 -4 src/sys/dev/uart/uart_cpu_sparc64.c > > Does this fix the serial console problems with the Blade100? If so then > I'll generate a March snapshot ASAP for it. > I expect it to but I don't have a Blade 100 to verify myself. I hope either Will or David will confirm that this fixes the problem seen on Blade 100 but it was a bug nevertheless. Marius