From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 21 17:00:15 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4608916A4CE for ; Thu, 21 Oct 2004 17:00:15 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1995543D3F for ; Thu, 21 Oct 2004 17:00:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9LH0EAr071207 for ; Thu, 21 Oct 2004 17:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9LH0Elj071206; Thu, 21 Oct 2004 17:00:14 GMT (envelope-from gnats) Resent-Date: Thu, 21 Oct 2004 17:00:14 GMT Resent-Message-Id: <200410211700.i9LH0Elj071206@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Christopher Nehren Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE00516A4CE for ; Thu, 21 Oct 2004 16:54:42 +0000 (GMT) Received: from prophecy.dyndns.org (pcp08490587pcs.levtwn01.pa.comcast.net [68.83.169.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DFA443D2F for ; Thu, 21 Oct 2004 16:54:42 +0000 (GMT) (envelope-from apeiron@prophecy.dyndns.org) Received: from prophecy.dyndns.org (localhost.dyndns.org [127.0.0.1]) by prophecy.dyndns.org (8.13.1/8.13.1) with ESMTP id i9LGsfjt075377 for ; Thu, 21 Oct 2004 12:54:41 -0400 (EDT) (envelope-from apeiron@prophecy.dyndns.org) Received: (from apeiron@localhost) by prophecy.dyndns.org (8.13.1/8.13.1/Submit) id i9LGseF2075376; Thu, 21 Oct 2004 12:54:40 -0400 (EDT) (envelope-from apeiron) Message-Id: <200410211654.i9LGseF2075376@prophecy.dyndns.org> Date: Thu, 21 Oct 2004 12:54:40 -0400 (EDT) From: Christopher Nehren To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/72968: Broken network support in x{mame,mess} partially failing silently X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Christopher Nehren List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 17:00:15 -0000 >Number: 72968 >Category: ports >Synopsis: Broken network support in x{mame,mess} partially failing silently >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Oct 21 17:00:14 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Christopher Nehren >Release: FreeBSD 5.3-BETA7 i386 >Organization: >Environment: System: FreeBSD prophecy.dyndns.org 5.3-BETA7 FreeBSD 5.3-BETA7 #0: Sun Oct 10 13:50:39 EDT 2004 root@prophecy.dyndns.org:/usr/src/sys/i386/compile/PROPHECY i386 >Description: As stated http://www.mail-archive.com/xmame@toybox.twisted.org.uk/msg07256.html, networking support is currently known to be broken in xmame and xmess. The port will still attempt to build network support, however, which will fail because the code is broken. Apparently the port maintainer wants the port to continue building but without networking support, and without notifying the user. This silent failure can cause much confusion (it did for me and others, at least). Therefore, I recommend marking the port as BROKEN rather than partially failing silently. This way a user isn't led to believe -- under false pretenses -- that their networking should still be working. Also take note that the port does not properly disable networking support even if it's enabled. >How-To-Repeat: Attempt to build recent xmame/xmess with networking support, notice the broken code. >Fix: --- /usr/ports/emulators/xmame/Makefile Thu Oct 21 12:49:05 2004 +++ xmame/Makefile Thu Oct 21 12:48:55 2004 @@ -223,11 +223,8 @@ #.endif .if ${WITH_NETWORK:L} != "no" -NETWORK= -.else -NETWORK=\# +BROKEN= "Network support is broken in 0.85+" .endif -#.endif .include >Release-Note: >Audit-Trail: >Unformatted: