From owner-freebsd-ports Sat May 20 14:12:36 2000 Delivered-To: freebsd-ports@freebsd.org Received: from sabami.seaslug.org (ip18.gte13.rb1.bel.nwlink.com [207.202.150.18]) by hub.freebsd.org (Postfix) with ESMTP id CC3FF37B643 for ; Sat, 20 May 2000 14:12:33 -0700 (PDT) (envelope-from scott@sabmail.rresearch.com) Received: from sabmail.rresearch.com (ip18.gte13.rb1.bel.nwlink.com [207.202.150.18]) by sabami.seaslug.org (Postfix) with SMTP id A9C151F7C for ; Sat, 20 May 2000 14:13:42 -0700 (PDT) To: freebsd-ports@FreeBSD.ORG Subject: Re: KDE2: make install 'fails' ... References: <87hfbuvwqh.fsf@sabmail.rresearch.com> <20000519220322.A45875@argon.blackdawn.com> <20000520081201.A29986@bone.nectar.com> Reply-To: scott@sabami.seaslug.org From: Scott Blachowicz Date: 20 May 2000 14:13:42 -0700 In-Reply-To: "Jacques A . Vidrine"'s message of "Sat, 20 May 2000 08:12:01 -0500" Message-ID: <87puqgncvt.fsf@sabmail.rresearch.com> Lines: 21 User-Agent: Gnus/5.0805 (Gnus v5.8.5) XEmacs/21.1 (Canyonlands) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > Please don't. If the comment is correct, then it should be something > like: > > #ifdef solaris > #include // for MAXDNAME > #endif > > Do not include any reference to __FreeBSD__ ... this is not a FreeBSD > issue. See my previous posting in this thread for more details. I agree with you, but... I don't have access to a Solaris box to know what the right thing for Solaris would be, no way to verify it and no way to know if some other platform is relying on that header file being there (i.e. no way to know if the comment is correct). It only REALLY makes a difference if these patches get fed back to the KDE developers - are you planning on doing that, Will? -- Scott Blachowicz To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message