From owner-cvs-all Sun Sep 6 01:53:46 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA23368 for cvs-all-outgoing; Sun, 6 Sep 1998 01:53:46 -0700 (PDT) (envelope-from owner-cvs-all) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA23360; Sun, 6 Sep 1998 01:53:40 -0700 (PDT) (envelope-from dillon@backplane.com) Received: (dillon@localhost) by apollo.backplane.com (8.8.8/8.6.5) id BAA23932; Sun, 6 Sep 1998 01:53:35 -0700 (PDT) Date: Sun, 6 Sep 1998 01:53:35 -0700 (PDT) From: Matthew Dillon Message-Id: <199809060853.BAA23932@apollo.backplane.com> To: "Andrey A. Chernov" Cc: Doug Rabson , John Birrell , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen sleep.c References: <199809051816.LAA22705@apollo.backplane.com> <19980906080311.A12205@nagual.pp.ru> Sender: owner-cvs-all@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ok, I'll commit it. -Matt :On Sat, Sep 05, 1998 at 09:58:19PM +0100, Doug Rabson wrote: :> On Sat, 5 Sep 1998, Matthew Dillon wrote: :> :> > The sleep code is totally broken in regards to its comparisons. The :> > argument is an unsigned int, but values are stored in time_t which is :> > currently a signed long. The code, as it stands, is not clean if either :> > time_t changes from signed to unsigned, or if time_t changes from a 32 bit :> > value to a 64 bit value. Since there is no harm in doing multiple :> > sleeps, why not just fix the code? We no tv_sec must be at least large :> > enough to hold INT_MAX, so: :> :> Looks fine to me. If Andrey agrees, why don't you commit this. : :Ok for me too. : :-- :Andrey A. Chernov :http://www.nagual.pp.ru/~ache/ :MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. (Please include original email in any response)