Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Dec 2018 05:25:41 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 233726] graphics/qgis: Update to 3.4.2
Message-ID:  <bug-233726-7788-zlAIHqTVov@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-233726-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-233726-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233726

Tobias C. Berner <tcberner@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ports-bugs@FreeBSD.org      |tcberner@freebsd.org
                 CC|                            |tcberner@freebsd.org
             Status|Open                        |In Progress

--- Comment #2 from Tobias C. Berner <tcberner@freebsd.org> ---
Moin moin

Thanks for the patch :)=20


I noticed some issues when looking at it:

-DQSCI_SIP_DIR:PATH=3D${LOCALBASE}/share/PyQt5/3.6/sip/Qsci=20
this should probably be=20
-DQSCI_SIP_DIR:PATH=3D${PYQT_APIDIR}

and this
-DSIP_DEFAULT_SIP_DIR:FILEPATH=3D${LOCALBASE}/share/PyQt5/3.6/sip
should be
-DQSCI_SIP_DIR:PATH=3D${PYQT_SIPDIR}



Instead of writing
CMAKE_ARGS=3D -DWITH_3D:BOOL=3DTRUE=20
you can do
CMAKE_ON=3D  WITH_3D
respectively=20
CMAKE_OFF=3D  WITH_QWTPOLAR



Instead of
GRASS_CMAKE_ON=3D         -DWITH_GRASS7:BOOL=3DTRUE
GRASS_CMAKE_OFF=3D        -DWITH_GRASS7:BOOL=3DFALSE
you could write=20
GRASS_CMAKE_BOOL=3D   WITH_GRASS7


* Your pre-configure looks like something for BINARY_ALIAS, or shebangfix
* Your post-configure targets should again use the ${OYQT_APIDIR}, otherwis=
e it
will only work for python-3.6.


* patch-cmake_PyQtMacros.cmake is wrong :D=20




mfg Tobias

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233726-7788-zlAIHqTVov>