From owner-freebsd-ports@FreeBSD.ORG  Sun Nov 13 12:50:49 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@FreeBSD.ORG
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 08CE416A420;
	Sun, 13 Nov 2005 12:50:49 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3AB1143D49;
	Sun, 13 Nov 2005 12:50:48 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.4/8.13.4) with ESMTP id jADColfn044399;
	Sun, 13 Nov 2005 15:50:47 +0300 (MSK)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.4/8.13.4/Submit) id jADColWP044398;
	Sun, 13 Nov 2005 15:50:47 +0300 (MSK) (envelope-from ache)
Date: Sun, 13 Nov 2005 15:50:47 +0300
From: Andrey Chernov <ache@FreeBSD.ORG>
To: Norikatsu Shigemura <nork@FreeBSD.ORG>
Message-ID: <20051113125046.GA44237@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Norikatsu Shigemura <nork@FreeBSD.ORG>, ports@FreeBSD.ORG
References: <200511130038.jAD0cgLb043746@sakura.ninth-nine.com>
	<20051113120157.GA42256@nagual.pp.ru>
	<20051113212402.bf0fe702.nork@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051113212402.bf0fe702.nork@FreeBSD.org>
User-Agent: Mutt/1.5.11
Cc: ports@FreeBSD.ORG
Subject: Re: Integrated DEBUG related macros to WITH_DEBUG/WITHOUT_DEBUG
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Nov 2005 12:50:49 -0000

On Sun, Nov 13, 2005 at 09:24:02PM +0900, Norikatsu Shigemura wrote:
> On Sun, 13 Nov 2005 15:01:58 +0300
> Andrey Chernov <ache@FreeBSD.ORG> wrote:
> > *DEBUG knob has different meaning from port to port and often not just -g 
> > adding, but turns on internal port debugging output/checks.
> > It means that it should be turned on/off separately on per port basis.
> > I.e. WITH_<portname>_DEBUG.
> > WITH_<portname>_* style options also allows to add them all into 
> > /etc/make.conf without creating name conflicts between the ports.
> 
> 	I don't think so.  There are 127ports supported DEBUG related
> 	knobs.  Only 127ports, and there are some ports which we
> 	request with DEBUG related knobs at the most.
> 
> 	'WITH_DEBUG' is well known and global knob.  This is POLA
> 	important.  If you want to turn on/off per port, you can
> 	set following description in /etc/make.conf.  This is ungy,
> 	sure.  But it's casual.


First of all, I don't see any sense to turn debug for all 127 ports at 
once. For many years the only need I see - turn for one of them. So it 
isn't "global knob" as you say. It is local per port knob and should not 
affect other ports.

> 
> .if ${.CURDIR} == "/usr/ports/foo/bar"
> WITH_DEBUG=	yes
> .endif
> .if ${.CURDIR} == "/usr/ports/bar/foo"
> WITH_DEBUG=	yes
> .endif


-- 
http://ache.pp.ru/