From owner-freebsd-current@FreeBSD.ORG Fri Oct 28 19:29:09 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FB3F16A41F; Fri, 28 Oct 2005 19:29:09 +0000 (GMT) (envelope-from delphij@frontfree.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id B96AC43D46; Fri, 28 Oct 2005 19:29:08 +0000 (GMT) (envelope-from delphij@frontfree.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 2E43CEB1493; Sat, 29 Oct 2005 03:29:07 +0800 (CST) Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id 67243-11; Sat, 29 Oct 2005 03:29:03 +0800 (CST) Received: from beastie.frontfree.net (unknown [211.71.95.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 09B68EB1491; Sat, 29 Oct 2005 03:29:02 +0800 (CST) Received: from localhost (localhost.frontfree.net [127.0.0.1]) by beastie.frontfree.net (Postfix) with ESMTP id C9CB8132690; Sat, 29 Oct 2005 03:28:58 +0800 (CST) Received: from beastie.frontfree.net ([127.0.0.1]) by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 92358-13; Sat, 29 Oct 2005 03:28:58 +0800 (CST) Received: by beastie.frontfree.net (Postfix, from userid 1001) id CECE51321E4; Sat, 29 Oct 2005 03:28:57 +0800 (CST) Date: Sat, 29 Oct 2005 03:28:57 +0800 From: Xin LI To: Mohan Srinivasan Message-ID: <20051028192857.GA92246@frontfree.net> References: <20051028165314.GA89706@frontfree.net> <20051028172249.66549.qmail@web31806.mail.mud.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <20051028172249.66549.qmail@web31806.mail.mud.yahoo.com> User-Agent: Mutt/1.4.2.1i X-GPG-key-ID/Fingerprint: 0xCAEEB8C0 / 43B8 B703 B8DD 0231 B333 DC28 39FB 93A0 CAEE B8C0 X-GPG-Public-Key: http://www.delphij.net/delphij.asc X-Operating-System: FreeBSD beastie.frontfree.net 5.4-RELEASE-p6 FreeBSD 5.4-RELEASE-p6 #4: Thu Jul 28 10:59:26 CST 2005 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386 X-URL: http://www.delphij.net X-By: delphij@beastie.frontfree.net X-Location: Beijing, China X-Virus-Scanned: amavisd-new at frontfree.net X-Virus-Scanned: amavisd-new at geekcn.org Cc: freebsd-current@FreeBSD.org, re@FreeBSD.org Subject: Re: [RELENG_6] NFS panic on locking against myself X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 19:29:09 -0000 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2005 at 10:22:49AM -0700, Mohan Srinivasan wrote: > I saw this once too. The following change should fix this. >=20 > @@ -965,7 +969,7 @@ > nfsmout: > if (error) { > if (newvp !=3D NULLVP) { > - vrele(newvp); > + vput(newvp); > *vpp =3D NULLVP; > } > if ((cnp->cn_nameiop =3D=3D CREATE || cnp->cn_nameiop =3D= =3D RENAME) && >=20 > Will check it into current soon. Ah!! Thanks for this, without your confirm I was still thinking about whether it's appropriate to replace the vrele() with vput()... To re@: Could we wait for some day to settle this change? Cheers, --=20 Xin LI http://www.delphij.net/ See complete headers for GPG key and other information. --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDYnv5/cVsHxFZiIoRAtUEAJ9pwv4kfqXp0Pz9FDi8E40jniYPjQCZAcP8 roCMNr+gpuxR0IOqh4rtZII= =O4Oz -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--