From owner-freebsd-bugs@FreeBSD.ORG Sat Mar 3 01:10:08 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C53E11065670 for ; Sat, 3 Mar 2012 01:10:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9E5A88FC16 for ; Sat, 3 Mar 2012 01:10:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q231A8rR092213 for ; Sat, 3 Mar 2012 01:10:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q231A84t092212; Sat, 3 Mar 2012 01:10:08 GMT (envelope-from gnats) Resent-Date: Sat, 3 Mar 2012 01:10:08 GMT Resent-Message-Id: <201203030110.q231A84t092212@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Vijay Singh Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E922106566B for ; Sat, 3 Mar 2012 01:03:54 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 1E6D08FC14 for ; Sat, 3 Mar 2012 01:03:54 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2313r2X006759 for ; Sat, 3 Mar 2012 01:03:53 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q2313rn5006741; Sat, 3 Mar 2012 01:03:53 GMT (envelope-from nobody) Message-Id: <201203030103.q2313rn5006741@red.freebsd.org> Date: Sat, 3 Mar 2012 01:03:53 GMT From: Vijay Singh To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/165643: Missing vnet restores in net/if_ethersubr.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 01:10:09 -0000 >Number: 165643 >Category: kern >Synopsis: Missing vnet restores in net/if_ethersubr.c >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 03 01:10:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Vijay Singh >Release: 9/stable >Organization: >Environment: >Description: There are some missing vnet restore in net/if_ethersubr.c that can cause networking code to execute in the wrong vnet context. A patch is provided here: [pc20 /u/vijay/bsd/CODE/9s/sys]# svn diff net/if_ethersubr.c Index: net/if_ethersubr.c =================================================================== --- net/if_ethersubr.c (revision 232242) +++ net/if_ethersubr.c (working copy) @@ -661,8 +661,10 @@ m = (*lagg_input_p)(ifp, m); if (m != NULL) ifp = m->m_pkthdr.rcvif; - else + else { + CURVNET_RESTORE(); return; + } } /* @@ -681,6 +683,7 @@ #endif ifp->if_ierrors++; m_freem(m); + CURVNET_RESTORE(); return; } >How-To-Repeat: >Fix: [pc20 /u/vijay/bsd/CODE/9s/sys]# svn diff net/if_ethersubr.c Index: net/if_ethersubr.c =================================================================== --- net/if_ethersubr.c (revision 232242) +++ net/if_ethersubr.c (working copy) @@ -661,8 +661,10 @@ m = (*lagg_input_p)(ifp, m); if (m != NULL) ifp = m->m_pkthdr.rcvif; - else + else { + CURVNET_RESTORE(); return; + } } /* @@ -681,6 +683,7 @@ #endif ifp->if_ierrors++; m_freem(m); + CURVNET_RESTORE(); return; } >Release-Note: >Audit-Trail: >Unformatted: