From owner-cvs-all Wed Feb 20 21:53:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id E124337B400 for ; Wed, 20 Feb 2002 21:52:25 -0800 (PST) Received: (qmail 23116 invoked from network); 21 Feb 2002 05:52:08 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([65.91.152.92]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 21 Feb 2002 05:52:08 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200202210437.g1L4btc69989@freefall.freebsd.org> Date: Thu, 21 Feb 2002 00:51:48 -0500 (EST) From: John Baldwin To: Bruce Evans Subject: RE: cvs commit: src/sys/kern sys_process.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 21-Feb-02 Bruce Evans wrote: > bde 2002/02/20 20:37:55 PST > > Modified files: > sys/kern sys_process.c > Log: > Recover bits that were lost in transition in rev.1.76: > - P_INMEM checks in all the functions. P_INMEM must be checked because > PHOLD() is broken. The old bits had bogus locking (using sched_lock) > to lock P_INMEM. After removing the P_INMEM checks, we were left with > just the bogus locking. > - large comments. They were too large, but better than nothing. I would much prefer that we fix phold/prele rather than do the bogus PS_INMEM checks if possible. > Remove obfuscations that were gained in transition in rev.1.76: > - PROC_REG_ACTION() is even more of an obfuscation than PROC_ACTION(). > > The change copies procfs_machdep.c rev.1.22 of i386/procfs_machdep.c > verbatim except for "fixing" the old-style function headers and adjusting > function names and comments. It doesn't remove the bogus locking. > > Approved by: des > > Revision Changes Path > 1.80 +77 -16 src/sys/kern/sys_process.c -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message