Date: Thu, 30 Jan 2003 22:03:06 +0100 (CET) From: Miguel Mendez <flynn@energyhq.homeip.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/47689: Maintainer Update: sysutils/thefish Message-ID: <200301302103.h0UL36FH000980@christine.energyhq.tk>
next in thread | raw e-mail | index | archive | help
>Number: 47689 >Category: ports >Synopsis: Maintainer Update: sysutils/thefish >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Thu Jan 30 13:10:03 PST 2003 >Closed-Date: >Last-Modified: >Originator: Miguel Mendez >Release: FreeBSD 5.0-RELEASE i386 >Organization: >Environment: System: FreeBSD christine.energyhq.tk 5.0-RELEASE FreeBSD 5.0-RELEASE #0: Thu Jan 16 23:49:01 CET 2003 root@christine.energyhq.tk:/usr/obj/usr/src/sys/CHRISTINE i386 >Description: It seems that during my GTK2-ification of the program, I somehow managed to fsck the 'text entry' signal handler. If you tried to modify a string in GTK2 fronted you'd be greeted with a segfault. The additional patch I've added solves it. Sorry for the inconvenience. >How-To-Repeat: >Fix: --- thefish.diff begins here --- diff -ruN thefish.old/Makefile thefish/Makefile --- thefish.old/Makefile Tue Jan 28 02:04:31 2003 +++ thefish/Makefile Thu Jan 30 21:52:34 2003 @@ -7,6 +7,7 @@ PORTNAME= thefish PORTVERSION= 0.2.5.1 +PORTREVISION= 1 CATEGORIES= sysutils MASTER_SITES= http://energyhq.homeip.net/files/ diff -ruN thefish.old/files/patch-aa thefish/files/patch-aa --- thefish.old/files/patch-aa Thu Jan 1 01:00:00 1970 +++ thefish/files/patch-aa Thu Jan 30 21:54:13 2003 @@ -0,0 +1,100 @@ +--- gtk_ui.c.orig Mon Jan 27 23:14:16 2003 ++++ gtk_ui.c Thu Jan 30 21:53:48 2003 +@@ -24,7 +24,7 @@ + OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +-$Id: //depot/fish/gtk_ui.c#25 $ ++$Id: //depot/fish/gtk_ui.c#26 $ + + */ + +@@ -268,22 +268,22 @@ + gtk_box_pack_start((GtkBox *)h_buttons, about_button, FALSE, FALSE, 0); + gtk_box_pack_start((GtkBox *) h_buttons, quit_button, FALSE, FALSE, 0); + +- g_signal_connect_swapped(GTK_OBJECT(window), "delete_event",\ ++ g_signal_connect(GTK_OBJECT(window), "delete_event",\ + GTK_SIGNAL_FUNC(delete_event), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(window), "destroy",\ ++ g_signal_connect(GTK_OBJECT(window), "destroy",\ + GTK_SIGNAL_FUNC(destroy), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(commit_button), "clicked",\ ++ g_signal_connect(GTK_OBJECT(commit_button), "clicked",\ + GTK_SIGNAL_FUNC(commit_pressed), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(quit_button), "clicked",\ ++ g_signal_connect(GTK_OBJECT(quit_button), "clicked",\ + GTK_SIGNAL_FUNC(quit_pressed), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(about_button), "clicked",\ ++ g_signal_connect(GTK_OBJECT(about_button), "clicked",\ + GTK_SIGNAL_FUNC(about_pressed), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(add_button), "clicked",\ ++ g_signal_connect(GTK_OBJECT(add_button), "clicked",\ + GTK_SIGNAL_FUNC(add_pressed), NULL); + + mytable1=gtk_table_new(num_knobs*2,3,FALSE); +@@ -323,10 +323,10 @@ + + } + +- g_signal_connect_swapped(GTK_OBJECT(radio_yes1[i]), "pressed",\ ++ g_signal_connect(GTK_OBJECT(radio_yes1[i]), "pressed",\ + GTK_SIGNAL_FUNC(radio_yes_pressed), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(radio_no1[i]), "pressed",\ ++ g_signal_connect(GTK_OBJECT(radio_no1[i]), "pressed",\ + GTK_SIGNAL_FUNC(radio_no_pressed), NULL); + + +@@ -424,7 +424,7 @@ + + gtk_entry_set_text((GtkEntry *)str_entry[i],work->value); + +- g_signal_connect_swapped(GTK_OBJECT(str_entry[i]), "changed",\ ++ g_signal_connect(GTK_OBJECT(str_entry[i]), "changed",\ + GTK_SIGNAL_FUNC(entry_modified), NULL); + + gtk_table_attach((GtkTable *)mytable2, (GtkWidget *) str_label[i] +@@ -914,13 +914,13 @@ + + add_yes_button = gtk_button_new_with_label("OK"); + +- g_signal_connect_swapped(GTK_OBJECT(add_yes_button), "clicked",\ ++ g_signal_connect(GTK_OBJECT(add_yes_button), "clicked",\ + GTK_SIGNAL_FUNC(add_yes_pressed), NULL); + + + add_no_button = gtk_button_new_with_label("Cancel"); + +- g_signal_connect_swapped(GTK_OBJECT(add_no_button), "clicked",\ ++ g_signal_connect(GTK_OBJECT(add_no_button), "clicked",\ + GTK_SIGNAL_FUNC(add_no_pressed), NULL); + + add_hsep = gtk_hseparator_new (); +@@ -1062,10 +1062,10 @@ + + } + +- g_signal_connect_swapped(GTK_OBJECT(radio_yes1[r_num]), "pressed",\ ++ g_signal_connect(GTK_OBJECT(radio_yes1[r_num]), "pressed",\ + GTK_SIGNAL_FUNC(radio_yes_pressed), NULL); + +- g_signal_connect_swapped(GTK_OBJECT(radio_no1[r_num]), "pressed",\ ++ g_signal_connect(GTK_OBJECT(radio_no1[r_num]), "pressed",\ + GTK_SIGNAL_FUNC(radio_no_pressed), NULL); + + knob_label[r_num]=gtk_label_new(r_ptr[r_num].name); +@@ -1102,7 +1102,7 @@ + + gtk_entry_set_text((GtkEntry *)str_entry[s_num],s_ptr[s_num].value); + +- g_signal_connect_swapped(GTK_OBJECT(str_entry[s_num]), "changed",\ ++ g_signal_connect(GTK_OBJECT(str_entry[s_num]), "changed",\ + GTK_SIGNAL_FUNC(entry_modified), NULL); + + gtk_table_attach((GtkTable *) mytable2, (GtkWidget *) str_label[s_num], --- thefish.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301302103.h0UL36FH000980>