From owner-cvs-all  Sat Jan  6 16:14:33 2001
From owner-cvs-all@FreeBSD.ORG  Sat Jan  6 16:14:29 2001
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3AF0D37B400; Sat,  6 Jan 2001 16:14:29 -0800 (PST)
Received: (from bright@localhost)
	by fw.wintelcom.net (8.10.0/8.10.0) id f070ERY25016;
	Sat, 6 Jan 2001 16:14:27 -0800 (PST)
Date: Sat, 6 Jan 2001 16:14:27 -0800
From: Alfred Perlstein <bright@wintelcom.net>
To: Bosko Milekic <bmilekic@technokratis.com>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/musycc musycc.c
Message-ID: <20010106161427.G15744@fw.wintelcom.net>
References: <200101062044.f06Kiex42615@freefall.freebsd.org> <20010106132943.E15744@fw.wintelcom.net> <005001c07839$40f06820$25cbca18@jehovah>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <005001c07839$40f06820$25cbca18@jehovah>; from bmilekic@technokratis.com on Sat, Jan 06, 2001 at 06:34:46PM -0500
Sender: bright@fw.wintelcom.net
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

* Bosko Milekic <bmilekic@technokratis.com> [010106 15:33] wrote:
> 
> I find this incredibly dumb. You're just wasting a check that need not be
> made. I know when I have to free m and when not to, it's dumb to have to
> check it again in errfree. It's Poul's call, however.

You have an exceptional condition, it reduces the amount of code
someone reading must digest and it should reduce the amount of code
the processor needs to put in the I cache.

There is also a lot of code that already does this:

sosend(), soreceive(), soclose().

What you're doing is giving a place to jump to further along in
case any other error conditions come up.

One other question, is since so much code does this (get a header
and attach an mbuf cluster) why not have a generic all-or-nothing
macro for this?

-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message