From owner-freebsd-current@FreeBSD.ORG  Fri Jun  6 13:48:00 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0DF5E552;
 Fri,  6 Jun 2014 13:48:00 +0000 (UTC)
Received: from thyme.infocus-llc.com (server.infocus-llc.com [206.156.254.44])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "*.infocus-llc.com", Issuer "*.infocus-llc.com" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id D423B22AE;
 Fri,  6 Jun 2014 13:47:59 +0000 (UTC)
Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net
 [75.65.60.66])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by thyme.infocus-llc.com (Postfix) with ESMTPSA id 5A86437B551;
 Fri,  6 Jun 2014 08:42:20 -0500 (CDT)
Received: by draco.over-yonder.net (Postfix, from userid 100)
 id 3glQ5R6L9fz8Dq; Fri,  6 Jun 2014 08:42:19 -0500 (CDT)
Date: Fri, 6 Jun 2014 08:42:19 -0500
From: "Matthew D. Fuller" <fullermd@over-yonder.net>
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: ZFS secondarycache on SSD problem on r255173
Message-ID: <20140606134219.GQ33666@over-yonder.net>
References: <20131017061248.GA15980@hell.ukr.net>
 <326B470C65A04BC4BC83E118185B935F@multiplay.co.uk>
 <20131017073925.GA34958@hell.ukr.net>
 <2AFE1CBD9B124E3AB9E05A4E483CCE03@multiplay.co.uk>
 <20131018080148.GA75226@hell.ukr.net>
 <256B2E5A0BA44DCBB45BB3F3E820E190@multiplay.co.uk>
 <20131018144524.GA30018@hell.ukr.net>
 <4459A6FAB7B8445C97CCB9EFF34FD4F0@multiplay.co.uk>
 <53144891.9050001@FreeBSD.org>
 <20140426012652.GA62784@over-yonder.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140426012652.GA62784@over-yonder.net>
X-Editor: vi
X-OS: FreeBSD <http://www.freebsd.org/>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Virus-Scanned: clamav-milter 0.98.3 at thyme.infocus-llc.com
X-Virus-Status: Clean
Cc: "Justin T. Gibbs" <gibbs@FreeBSD.org>,
 Steven Hartland <killing@multiplay.co.uk>, freebsd-current@FreeBSD.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jun 2014 13:48:00 -0000

On Fri, Apr 25, 2014 at 08:26:52PM -0500 I heard the voice of
Matthew D. Fuller, and lo! it spake thus:
> On Mon, Mar 03, 2014 at 11:17:05AM +0200 I heard the voice of
> Andriy Gapon, and lo! it spake thus:
> > 
> > I noticed that on some of our systems we were getting a clearly
> > abnormal number of l2arc checksum errors accounted in l2_cksum_bad.
> > [...]
> > I propose the following patch which has been tested and seems to fix
> > the problem without introducing any side effects:
> 
> I've been running this for >2 weeks now without any cksum_bad's
> showing up (long enough that without it, I'd have expected them),
> and no other obvious side effects.

Another 6 weeks on, still working fine and still seems to fix the
issue.  Any reason not to commit it?


-- 
Matthew Fuller     (MF4839)   |  fullermd@over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.