From owner-svn-src-all@freebsd.org Thu Sep 17 08:15:41 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 915039C26F0; Thu, 17 Sep 2015 08:15:41 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 85E5311F5; Thu, 17 Sep 2015 08:15:41 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 8477F1F16; Thu, 17 Sep 2015 08:15:41 +0000 (UTC) Date: Thu, 17 Sep 2015 08:15:41 +0000 From: Alexey Dokuchaev To: Steven Hartland Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287886 - head/sys/sys Message-ID: <20150917081541.GA65088@FreeBSD.org> References: <201509170003.t8H03uSf070155@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201509170003.t8H03uSf070155@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 08:15:41 -0000 On Thu, Sep 17, 2015 at 12:03:56AM +0000, Steven Hartland wrote: > New Revision: 287886 > URL: https://svnweb.freebsd.org/changeset/base/287886 > > Log: > Fix kqueue write events for files > 2GB > > Due to the use of int's for file offsets in the VOP_WRITE_(PRE|POST) > macros, kqueue write events for files greater 2GB where never fired. > > This caused tail -f on a file greater 2GB to never see updates. Oh that's an embarrassing bug. > MFC after: 1 week Would you also consider merging to stable/8? Thanks, ./danfe