From owner-freebsd-current  Sun Oct 20 18:30:29 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id SAA09658
          for current-outgoing; Sun, 20 Oct 1996 18:30:29 -0700 (PDT)
Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id SAA09653;
          Sun, 20 Oct 1996 18:30:27 -0700 (PDT)
Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.0/CET-v2.1) with SMTP id BAA20791; Mon, 21 Oct 1996 01:30:25 GMT
Date: Mon, 21 Oct 1996 10:30:25 +0900 (JST)
From: Michael Hancock <michaelh@cet.co.jp>
To: phk@FreeBSD.ORG
cc: current@FreeBSD.ORG
Subject: Re: <sys/queue.h>
In-Reply-To: <24020.845822819@critter.tfs.com>
Message-ID: <Pine.SV4.3.93.961021101256.20316C-100000@parkplace.cet.co.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Sun, 20 Oct 1996, Poul-Henning Kamp wrote:

> 
> As much as I like this file there's one detail that I hate:
> 
> 	/*
> 	 * Singly-linked List definitions.
> 	 */
> 	#define SLIST_HEAD(name, type)                                  \
> 	struct name {                                                   \
> -		struct type *slh_first; /* first element */             \
> +		type *slh_first; /* first element */ 			\
> 	}

If anything should be changed, it should be the name 'type'.  It's
miss-used here:

#define SLIST_HEAD(name, tag)	\
struct name {			\
	struct tag *slh_first;	\
}

Regards,


Mike Hancock