From owner-freebsd-current Mon Sep 22 10:45:44 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id KAA03430 for current-outgoing; Mon, 22 Sep 1997 10:45:44 -0700 (PDT) Received: from ns.mt.sri.com (SRI-56K-FR.mt.net [206.127.65.42]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id KAA03414 for ; Mon, 22 Sep 1997 10:45:38 -0700 (PDT) Received: from rocky.mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.7/8.8.7) with ESMTP id LAA13814; Mon, 22 Sep 1997 11:45:25 -0600 (MDT) Received: (from nate@localhost) by rocky.mt.sri.com (8.7.5/8.7.3) id LAA01369; Mon, 22 Sep 1997 11:45:24 -0600 (MDT) Date: Mon, 22 Sep 1997 11:45:24 -0600 (MDT) Message-Id: <199709221745.LAA01369@rocky.mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Julian Elischer Cc: "Justin T. Gibbs" , Bruce Evans , nate@mt.sri.com, current@freebsd.org Subject: Re: cvs commit: src/sys/conf files src/sys/dev/vx if_vx.c if_vxreg.h src/sys/i386/apm apm.c src/sys/i386/conf GENERIC files.i386 src/sys/i386/eisa 3c5x9.c aha1742.c aic7770.c bt74x.c eisaconf.c eisaconf.h if_fea.c if_vx_eisa.c src/sys/i386/i386 a In-Reply-To: <3426AA40.41C67EA6@whistle.com> References: <199709221347.HAA15157@pluto.plutotech.com> <3426AA40.41C67EA6@whistle.com> X-Mailer: VM 6.29 under 19.15 XEmacs Lucid Sender: owner-freebsd-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > The thing I don't like abut what has been done is: > > It's changed a very standard and well understood service in the kernel. > I think you should have left it the same and implimented a cam_timeout > facility that runs separatly. In theory, I disagree. We can't 'move forward' w/out breaking device compatability with other systems, and if the changes allow to effeciently do things in the manner described in the paper, it's a step in the right direction. For example, making the VM system 'useful' required changing a standard kernel interface (although it was neither well documented nor well understood.) But, I want to know that it is indeed an improvement, and not merely a change that is needed to support Justin's CAM work, and something that could have been done in a manner that took the good ideas from the work but implemented them in a manner that was less intrusive. > all my drivers that are shared between various OS now need to > be modified, with a new #if defined(__FreeBSD__) in them. Actually, if Justin's work was the same as the original code, you should still be able to use the old 'timeout' functionality, it just doens't take advantage of some of the newer features. Nate