From owner-freebsd-current  Fri Nov  8  5:18:39 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E3C7E37B401; Fri,  8 Nov 2002 05:18:37 -0800 (PST)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.130.111.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B2E0643E6E; Fri,  8 Nov 2002 05:18:36 -0800 (PST)
	(envelope-from pfeifer@dbai.tuwien.ac.at)
Received: from naos (naos [128.130.111.28])
	by vexpert.dbai.tuwien.ac.at (8.12.6/8.12.6) with ESMTP id gA8DIJGX020527;
	Fri, 8 Nov 2002 14:18:21 +0100 (CET)
Date: Fri, 8 Nov 2002 14:18:17 +0100 (CET)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: Pierre Beyssac <beyssac@enst.fr>
Cc: Pierre Beyssac <pb@fasterix.frmug.org>,
	Dag-Erling Smorgrav <des@ofug.org>,
	Krzysztof J?druczyk <beaker@hot.pl>, <freebsd-current@freebsd.org>,
	Poul-Henning Kamp <phk@freebsd.org>, Alfred Perlstein <bright@mu.org>
Subject: Re: Wine-2002.10.07 port on FreeBSD 5.0-current
In-Reply-To: <20021108140401.A44559@bofh.enst.fr>
Message-ID: <Pine.BSF.4.44.0211081411050.74479-100000@naos.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Fri, 8 Nov 2002, Pierre Beyssac wrote:
> Fine, but if included "as is" in Wine because, it will break
> compatibility with Net/OpenBSD because DBREG_DRX is a FreeBSDism...
> that's why I surrounded my patch with a #ifdef DBREG_DRX (which
> seems cleaner than a #ifdef __FreeBSD__).

Sheesh.

PHK, now we have the situation where user programs require #ifdefs
to be portable among the BSDs when this was not required before.

Please consider reverting

  revision 1.28
  date: 2002/10/20 20:48:56;  author: phk;  state: Exp;  lines: +6 -9
  Change the definition of the debugging registers to be an array, so
  that we can index into it, rather than do pointer gymnastics on a
  structure containing 8 elements.

in src/sys/i386/include/reg.h.

Gerald

PS: Pierre, thanks a lot for spotting and addressing this! I certainly
agree with preferring #ifdef DBREG_DRX over #ifdef __FreeBSD__.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message