Date: Tue, 09 Sep 2014 13:17:31 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193474] security/webshag: some ports improvements. Message-ID: <bug-193474-13-vwPtq3iTEw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193474-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193474-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193474 Jason E. Hale <jhale@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Triage |In Discussion CC| |jhale@FreeBSD.org Assignee|freebsd-ports-bugs@FreeBSD. |jhale@FreeBSD.org |org | --- Comment #2 from Jason E. Hale <jhale@FreeBSD.org> --- Patch looks fine for the issues that were brought up, but there are other issues that should have been addressed before this port was added: - webshag.conf should probably be installed as webshag.conf.sample and use the @sample keyword in pkg-plist so that edited configs don't get overwritten. - patch-setup_linux_py uses hard-coded paths for PREFIX and LOCALBASE...this should be fixed. You could use %%PREFIX%% and %%LOCALBASE%% in the patch instead, then use a post-patch replacement. - Python bytecode should be pre-generated with and without the -O flag (.pyo and .pyc files) for everything installed in PYTHON_SITELIBDIR so there are no leftovers. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193474-13-vwPtq3iTEw>