Date: Thu, 15 Jan 2004 01:08:18 +1100 From: Tim Robbins <tjr@freebsd.org> To: Don Lewis <truckman@freebsd.org> Cc: current@freebsd.org Subject: Re: simplifying linux_emul_convpath() Message-ID: <20040114140818.GA15471@cat.robbins.dropbear.id.au> In-Reply-To: <200401141308.i0ED8p7E039161@gw.catspoiler.org> References: <200401141308.i0ED8p7E039161@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 14, 2004 at 05:08:51AM -0800, Don Lewis wrote: > I just stumbled across a vnode locking violation in > linux_emul_convpath(). Rather than locking and unlocking each vnode for > the VOP_GETATTR() calls, is there any reason that this code should not > be simplified to just compare the vnode pointers rather than fetching > the vnode attributes and comparing the attributes for equality. I'm having trouble convincing myself that comparing vnode pointers would work with stackable filesystems. Then again, null_getattr() changes va_fsid, so linux_emul_convpath() may not handle stacking properly right now anyway. Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040114140818.GA15471>