Date: Thu, 01 Mar 2001 13:30:44 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: "Matthew N. Dodd" <winter@jurai.net> Cc: Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aac aac_pci.c src/sys/dev/advansys a Message-ID: <XFMail.010301133044.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0103011531420.43971-100000@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01-Mar-01 Matthew N. Dodd wrote: > On Thu, 1 Mar 2001, John Baldwin wrote: >> On 01-Mar-01 Matthew N. Dodd wrote: >> > Wouldn't this sort of thing be better handled in the bus code? >> >> *shrug* The same has been said of the RF_NOSHARE flag for interrupt >> resources. Whatever floats your boat.. > > I'm not sure about the PCI stuff but uncommitted code for the EISA and MCA > busses doens't require the driver deal that detail as the bus actually > knows about it directly. > > What provision is made for turning off entropy harvesting on a per device > instance basis? A hint readable by the bus driver would do this nicely as > well dynamic sysctl node to allow runtime configuration. there is none right now. It's actually a interrupt source property that is true if any of the interrupt handlers say it is true. Since in theory busses own interrupt sources (you can't share an interrupt source across busses for any of the busses that I know of AFAIK) they might be better off setting this property themselves with hints from the drivers. > Forcing device drivers to contain specific knowledge of bus internals > seems like a really bad idea. The original intention was that a device driver is in the position to know if its interrupt source is somewhat random or not. For example, a clock interrupt might not be a good source of entropy in theory or not of good as one as an ethernet driver might be.. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010301133044.jhb>