Date: Wed, 8 Aug 2007 17:57:51 +0200 From: Bernd Walter <ticso@cicely12.cicely.de> To: "M. Warner Losh" <imp@bsdimp.com> Cc: freebsd-arm@freebsd.org, ticso@cicely.de Subject: Re: CENTIPAD boot Message-ID: <20070808155750.GO41893@cicely12.cicely.de> In-Reply-To: <20070808.093920.-432838389.imp@bsdimp.com> References: <46B9CAD8.4040103@bulinfo.net> <20070808144152.GM41893@cicely12.cicely.de> <46B9DD23.70608@bulinfo.net> <20070808.093920.-432838389.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 08, 2007 at 09:39:20AM -0600, M. Warner Losh wrote:
> In message: <46B9DD23.70608@bulinfo.net>
> Krassimir Slavchev <krassi@bulinfo.net> writes:
> : > Please split BOOT_BWCT and BOOT_CENTIPAD here, since I localy have
> : > 0xAC added as a valid status:
> : > #ifdef BOOT_BWCT
> : > value = GetFlashStatus();
> : > if ((value & 0xFC) != 0xAC
> : > && (value & 0xFC) != 0xB4)
> : > printf(" Bad SPI status: 0x%x\n", value);
> : > #else
> : > This is because I use AT45DB161D chips in production.
> : > The 0xB4 is from the AT45DB321C, which I'd used in prototypes only.
> : > I might use other SPI types for special purspose as well.
> :
> : Feel free to change anything you wish!
>
> I think we need just a little more smarts here. What this check is
> doing is making sure that the ID is sane, which doesn't make sense for
> a general solution.
It might not be important for the normal use.
I locally use it for post production tests, but I've added memory tests
as well, so I can quickly find out if there is a data or address line
failure, which is active in boot0spi only and won't get shipped.
But I know what I can expect from the SPI, so just printing the value
will have the same effect.
When we do the SPI autoprobing one day and print the result, this is
likely to be even better.
Patching the binary with the correct dataflash parameters should be
easy.
--
B.Walter http://www.bwct.de http://www.fizon.de
bernd@bwct.de info@bwct.de support@fizon.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070808155750.GO41893>