From owner-freebsd-current  Tue Nov 13 12:27: 4 2001
Delivered-To: freebsd-current@freebsd.org
Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205])
	by hub.freebsd.org (Postfix) with ESMTP id B0B4837B405
	for <current@freebsd.org>; Tue, 13 Nov 2001 12:27:02 -0800 (PST)
Received: (qmail 12595 invoked from network); 13 Nov 2001 20:27:01 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <fjoe@iclub.nsu.ru>; 13 Nov 2001 20:27:01 -0000
Message-ID: <XFMail.011113122701.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20011114021956.B10325@iclub.nsu.ru>
Date: Tue, 13 Nov 2001 12:27:01 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Max Khon <fjoe@iclub.nsu.ru>
Subject: RE: initgroups
Cc: current@freebsd.org
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


On 13-Nov-01 Max Khon wrote:
> hi, there!
> 
> Any objections if I will commit the following patch (see PR/15421)?
> 
> Index: initgroups.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
> retrieving revision 1.4
> diff -u -r1.4 initgroups.c
> --- initgroups.c      2001/08/29 13:52:26     1.4
> +++ initgroups.c      2001/11/13 20:17:03
> @@ -59,9 +59,5 @@
>       if (getgrouplist(uname, agroup, groups, &ngroups) < 0)
>               warnx("%s is in too many groups, using first %d",
>                   uname, ngroups);
> -     if (setgroups(ngroups, groups) < 0) {
> -             _warn("setgroups");
> -             return (-1);
> -     }
> -     return (0);
> +     return setgroups(ngroups, groups);
>  }

Style nit:

        return (setgruops(ngroups, groups));


Also, commit the manpage patch in the PR as well.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message