Date: Wed, 19 Feb 2014 19:50:01 GMT From: oliver <oliver@beefrankly.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/186294: calendar(1): calendar' preprocessor process comments Message-ID: <201402191950.s1JJo1Mj078698@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/186294; it has been noted by GNATS.
From: oliver <oliver@beefrankly.org>
To: bug-followup@FreeBSD.org, romain@FreeBSD.org
Cc:
Subject: Re: bin/186294: calendar(1): calendar' preprocessor process
comments
Date: Wed, 19 Feb 2014 20:47:24 +0100
Hello Romain,
that is very true...when removing the original block, I didn't remove
the while condition, even stepping through is not anymore required.
Sorry, I will fix that.
For so long, please don't commit the patch. I'm digging a bit deeper
for PR: bin/162211 and found another issue..please stand by, will
post the corrected version shortly...but need to make other
tests first.
Greetings, Oliver
>Hi Oliver,
>On Wed, Feb 19, 2014 at 06:16:25PM +0100, oliver wrote:
>> sorry wrong patch file, patch again - correct version.
>After applying this patch, I confirm this problem is fixed.
>> + } else if (idx_ts != NULL && idx_te == NULL) {
>> + if (cf == 0) {
>> + cf = 1;
>> + while (buf++ != idx_ts);
> ^^^^^^^^^^^^^^^^^^^^^^^
>While copying/pasting the patch, this line confused me a bit. Isn't it
>more obvious to write this as a simple assignment ?
>> buf = idx_ts + 1;
>Thanks!
>Romain
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402191950.s1JJo1Mj078698>