From owner-freebsd-bugs@FreeBSD.ORG  Sat Jun 21 20:30:08 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3D1451065672
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 21 Jun 2008 20:30:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D74618FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 21 Jun 2008 20:30:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5LKU7Rh033915
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 21 Jun 2008 20:30:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5LKU7gG033911;
	Sat, 21 Jun 2008 20:30:07 GMT (envelope-from gnats)
Date: Sat, 21 Jun 2008 20:30:07 GMT
Message-Id: <200806212030.m5LKU7gG033911@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Garrett Cooper" <yanegomi@gmail.com>
Cc: 
Subject: Re: bin/45529: [patch] hexdump(1) core-dumps with certain args
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <yanegomi@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jun 2008 20:30:08 -0000

The following reply was made to PR bin/45529; it has been noted by GNATS.

From: "Garrett Cooper" <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, drj@pobox.com
Cc:  
Subject: Re: bin/45529: [patch] hexdump(1) core-dumps with certain args
Date: Sat, 21 Jun 2008 13:23:03 -0700

 This patch fixes the issue (at least from what I can tell):
     http://yanegomi-fbsd-patches.googlecode.com/files/hexdump_parse_fix_draft1.patch
 
 I also fixed the regression script:
     http://yanegomi-fbsd-patches.googlecode.com/files/hexdump_regr.sh
 
 Cheers,
 -Garrett
 
 Proof:
 
 [gcooper@optimus /devel/ncvs/src/usr.bin/hexdump]$
 /devel/hexdump_regr.sh hexdump
 hexdump -e "%,"
 hexdump: "%,": bad format
 hexdump -e "/1 "%03","
 hexdump: "/1 "%03",": bad format
 hexdump -e "/1 "\%o","
 hexdump: "/1 "\%o",": bad format
 hexdump -e "/1 "\t%03o","
 hexdump: "/1 "\t%03o",": bad format
 hexdump -e "/1 "\\%03o","
 hexdump: "/1 "\\%03o",": bad format
 hexdump -e "2/1 """
 Segmentation fault (core dumped)
 [gcooper@optimus /devel/ncvs/src/usr.bin/hexdump]$
 /devel/hexdump_regr.sh ./hexdump
 ./hexdump -e "%,"
 hexdump: "%,": bad format
 ./hexdump -e "/1 "%03","
 hexdump: "/1 "%03",": bad format
 ./hexdump -e "/1 "\%o","
 hexdump: "/1 "\%o",": bad format
 ./hexdump -e "/1 "\t%03o","
 hexdump: "/1 "\t%03o",": bad format
 ./hexdump -e "/1 "\\%03o","
 hexdump: "/1 "\\%03o",": bad format
 ./hexdump -e "2/1 """
 hexdump: "2/1 """: bad format