Date: Wed, 5 Sep 2001 20:25:04 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch file.c Message-ID: <20010905202504.A51847@nagual.pp.ru> In-Reply-To: <xzpbskpsmas.fsf@flood.ping.uio.no> References: <200109051222.f85CMS414529@freefall.freebsd.org> <20010905181734.B50064@nagual.pp.ru> <xzpbskpsmas.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 05, 2001 at 17:13:31 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <ache@nagual.pp.ru> writes: > > > Use fseeko() instead of fseek() (u->offset is already an off_t), and mark > > > some function arguments as unused. > > Please don't forget to change lib/libfetch that way too. > > Please don't forget to make sense :) > If you mean usr.bin/fetch/fetch.c, the fseek() there is redundant, and I mean lib/libfetch/file.c Please remember that fseek() not works for >2GB offsets. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010905202504.A51847>