Date: Thu, 18 Nov 2010 16:55:44 +0100 From: Thomas Gellekum <Thomas.Gellekum@gmx.de> To: Pav Lucistnik <pav@FreeBSD.org> Cc: glewis@FreeBSD.org, freebsd-eclipse@FreeBSD.org Subject: Re: [Fwd: eclipse-devel-3.6.1 failed on amd64 8] Message-ID: <86tyjehbi7.fsf@siegel.tg.intern> In-Reply-To: <4CE52A6A.4070503@FreeBSD.org> (Pav Lucistnik's message of "Thu, 18 Nov 2010 14:30:18 %2B0100") References: <1289338625.11542.1.camel@hood.oook.cz> <86y68qhjp7.fsf@siegel.tg.intern> <4CE52A6A.4070503@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Pav Lucistnik <pav@FreeBSD.org> writes:
> On 2010/11/18 13:58, Thomas Gellekum wrote:
>> Looking at the error report again:
>>
>>>> PATCH_DEPENDS=apache-ant-1.7.1.tbz desktop-file-utils-0.15_2.tbz gamin-0.1.10_4.tbz gettext-0.18.1.1.tbz gio-fam-backend-2.24.2.tbz glib-2.24.2.tbz inputproto-2.0.tbz javavmwrapper-2.3.5.tbz jdk-1.6.0.3p4_19.tbz kbproto-1.0.4.tbz libX11-1.3.3_1,1.tbz libXau-1.0.5.tbz libXdmcp-1.0.3.tbz libXext-1.1.1,1.tbz libXi-1.3,1.tbz libXtst-1.1.0.tbz libiconv-1.13.1_1.tbz libpthread-stubs-0.3_3.tbz libxcb-1.7.tbz patch-2.6.1_1.tbz pcre-8.10.tbz perl-5.10.1_3.tbz pkg-config-0.25_1.tbz python26-2.6.6.tbz recordproto-1.14.tbz xextproto-7.1.1.tbz xproto-7.0.16.tbz zip-3.0.tbz
>>
>> This defines a dependency on jdk-1.6.0.3p4_19, whereas we explicitly
>> specify JAVA_VENDOR=openjdk in the makefile. Do we need to do anything
>> special to make the patch phase recognize the dependency correctly? Are
>> there just some definitions missing from bsd.java.mk?
>
> You don't have PATCH_DEPENDS on java in this port. The java you're
> looking at is dragged in via apache-ant.
I see. Can someone please commit the attached patch?
tg
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=eclipse-devel.diff
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/java/eclipse-devel/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- Makefile 17 Nov 2010 20:45:28 -0000 1.34
+++ Makefile 18 Nov 2010 15:42:23 -0000
@@ -28,14 +28,13 @@
EXTRACT_DEPENDS=${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip
PATCH_DEPENDS= ant:${PORTSDIR}/devel/apache-ant \
gpatch:${PORTSDIR}/devel/patch \
- zip:${PORTSDIR}/archivers/zip
+ zip:${PORTSDIR}/archivers/zip \
+ ${DEPEND_JAVA}
BUILD_DEPENDS= gpatch:${PORTSDIR}/devel/patch \
unzip:${PORTSDIR}/archivers/unzip \
zip:${PORTSDIR}/archivers/zip
LIB_DEPENDS= cairo.2:${PORTSDIR}/graphics/cairo
-BROKEN= does not build
-
OPTIONS= TESTS "Build SDK test suite" off
ONLY_FOR_ARCHS= i386 amd64
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86tyjehbi7.fsf>