Date: Thu, 11 Dec 2008 10:32:52 -0800 From: Oleksandr Tymoshenko <gonzo@bluezbox.com> To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r185925 - in head/contrib/binutils: bfd gas/config ld/emulparams Message-ID: <49415CD4.7090904@bluezbox.com> In-Reply-To: <86oczjklk8.fsf@ds4.des.no> References: <200812110822.mBB8MKLd059320@svn.freebsd.org> <86oczjklk8.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > Warner Losh <imp@FreeBSD.org> writes: >> Author: imp >> Date: Thu Dec 11 08:22:20 2008 >> New Revision: 185925 >> URL: http://svn.freebsd.org/changeset/base/185925 >> >> Log: >> Push mips support into the tree. > > Just to pick a random mips commit - > > There is something wrong with the mips toolchain. The build breaks in > libpam, while building the static version, which includes all modules: > > ../modules/pam_deny/libpam_deny.a(pam_deny.o)(.text+0x3c): In function `pam_sm_open_session': > /src/lib/libpam/modules/pam_deny/pam_deny.c:80: multiple definition of `pam_sm_open_session' > ../modules/pam_chroot/libpam_chroot.a(pam_chroot.o)(.text+0x14):/src/lib/libpam/modules/pam_chroot/pam_chroot.c:54: first defined here > [lather, rinse, repeat for every service function in every module] > > The service functions should be static. The logic PAM uses to determine > whether it is building static or shared modules is as follows: > > #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES) Using ABI calls (-mabicalls) assume -fPIC. This issue is known for a long time now and I proposed a fix but didn't have enough time to get/commit proper solution. We discussed it about three months ago: http://lists.freebsd.org/pipermail/freebsd-arch/2008-August/008430.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49415CD4.7090904>