From owner-svn-ports-all@FreeBSD.ORG  Tue Apr  7 06:32:03 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 78D8A64A;
 Tue,  7 Apr 2015 06:32:03 +0000 (UTC)
Received: from gw.catspoiler.org (cl-1657.chi-02.us.sixxs.net
 [IPv6:2001:4978:f:678::2])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 259B48B5;
 Tue,  7 Apr 2015 06:32:03 +0000 (UTC)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id t376VnAp041310;
 Mon, 6 Apr 2015 23:31:53 -0700 (PDT)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201504070631.t376VnAp041310@gw.catspoiler.org>
Date: Mon, 6 Apr 2015 23:31:49 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: svn commit: r383472 - head/audio/muse
To: danfe@FreeBSD.org
In-Reply-To: <20150407012902.GA22994@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: sunpoet@FreeBSD.org, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2015 06:32:03 -0000

On  7 Apr, Alexey Dokuchaev wrote:
> On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh wrote:
>> New Revision: 383472
>> URL: https://svnweb.freebsd.org/changeset/ports/383472
>> 
>> [...]
>> @@ -52,6 +49,6 @@ post-patch:
>>  
>>  post-install:
>>  	@${MKDIR} ${STAGEDIR}${DOCSDIR}
>> -	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
>> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> 
> Please do not change working and readable code into equivalent less-readable
> one.

I'm not particularly fond of either the original or the update, but the
original is obscure enough that I'd have to dig out the manual to figure
out what it even does.