Date: Mon, 19 Oct 1998 09:41:00 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: Anyone got any ideas? getblk/pgtblk/inode lockup Message-ID: <199810191641.JAA16458@apollo.backplane.com> References: <199810191033.UAA11898@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
:> process.
:
:PG_BUSY is cleared without a wakeup in vfs_bio.c and vm_kern.c. The wakeup
:is apparently important in vfs_bio.c. Untested fix + cosmetic fix for not
:always using the specialized inline function for doing the wakeup:
:
:diff -c2 kern/vfs_bio.c~ kern/vfs_bio.c
:*** kern/vfs_bio.c~ Wed Oct 14 03:22:21 1998
:...
Yah, I noticed those too. I'm going to wait to see if luoqi's
patch fixes my specific lockup, a week or two, and then look
more closely at those two cases. We probably want to patch
them. Actually, we probably want to get rid of *ALL* the
calls to vm_page_flag_clear(m, PG_BUSY) and replace them
with vm_page_wakeup(). Hmm... in fact, we may want to
get rid of all external access to vm_page_flag_clear()
and vm_page_flag_set() and instead provide specific
functions for the setting of specific flags, in order
to encapsulate the side effects.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810191641.JAA16458>