Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Sep 2009 16:11:37 +0400
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        Zvezdelin Vladov <zvladov@gmail.com>
Cc:        ports@FreeBSD.org, stas@freebsd.org, anikina@gmail.com, zhnichkov@gmail.com, theraphim@gmail.com
Subject:   Re: Flow-tools and Flow-tools-ng - Flow-Capture - supposed to be memory  leak - patch
Message-ID:  <20090927161137.4becc379.stas@FreeBSD.org>
In-Reply-To: <c3a09b6b0908150004t5556522hbaa3933153ed09b3@mail.gmail.com>
References:  <c3a09b6b0908150004t5556522hbaa3933153ed09b3@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Sun__27_Sep_2009_16_11_37_+0400_R5A6i2cr969czDmR
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, 15 Aug 2009 10:04:46 +0300
Zvezdelin Vladov <zvladov@gmail.com> mentioned:

> Dear Sir/Madam,
>=20
> Please, publish in the official ports build patch system, the patch
> bellow for the problem
> that manifest itself only on the amd64 platform, and it is one and the
> same for both the
> flow-tools and flow-tools-ng - i.e. flow-capture eats all of the RAM
> and SWAP of the
> machine, until killed by the kernel.
>=20
> The problem itself is in the built-in mechanism in the flow-tools,(
> instead of using the
> macros in the FreeBSD,) to read msg structures and control-information
> from recvmsg
> calls.
>=20
> I've managed to patch myself the source, but my patch is ugly one, and
> consist of
> just commenting out the usage of the hack-in tools to read msg structures=
 of the
> original source (but worked).
>=20
> The patch I am pasting here is from the author, and concerns the same pro=
blem.
> It looks much better than mine, and If I've new about it, I would be
> spending 4 days
> debugging....;-(
>=20

Hello, Zvezdelin!

Can you elaborate a bit more on the patch contents?  I'm not entirely sure
what it does and furthermore flow-tools source code does not contain any
references to the CMSG_XXX macros, so it is effectively a no-op for
net/flow-tools.  It might work for flow-tools-ng though.

It'd be helpful to have a small description of what these changes does,
so it will be possible to elaborate the same fix for net/flow-tools.=20

--=20
Stanislav Sedov
ST4096-RIPE

--Signature=_Sun__27_Sep_2009_16_11_37_+0400_R5A6i2cr969czDmR
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJKv1Z+AAoJEKN82nOYvCd0Q6IP/Rx7HLG11MaCgOPT8UVay7Hk
j0fOV4wNIT+oYDCecSPIhbh4vcDDRZNmT46HRjhRPk6yDWpo0tKirAOOWHWSVhR5
P5Ns2dQZXaQuBnxP71kN8w4uHUYSw0LMh2EX189puGAr/jjizRyBrRmRHOlRDNFB
r/YJWpX5Hz3MXcRyiQdHwsdBBEDueDOKghPluoT8hQ9wE4f61wTGfNsRrLpPOSDk
RDxuBVIKM6aedcI7wqnT0AEfhqycvH68i/37LYyCxaH1MvGNefcnGdFHo1z79C1J
JJ5PNly/St5tXtUL5hMZ6orG42vNDG5uC42YEUqpeNCIUlKJW4orPqPW9wt0zdBb
G/ixhzbXtBDD/5vO3yszNehyjTrVtaDjS9Rgy8dEk+ButNiDIVE0jt+T3bURq6zT
5OJwH9+/hT8+vQKLFvJjwPElUM74wjvn5YpyqVUKZzDAKDoDU27WLTpE0OUjtbxC
No5vWvAtzoEYbvcOdKn0egUkjsPAGtsrXc/ZGP/iVmX6ToQDidJ5WAY4LgsGPtLe
lLvVTXyAtBeEJxK6dwpz8bfTKtr5wBJ/rs/RFYwumUItX9SBtG+78bmfQmyNDjEs
fS+ufBscW+0f0mTWIT2Enm4tyVZK4BCsOsT7Xt1dblmjv8S9MjtM0VlJczR0eGtb
SsOfTtBi++QDDzy30Ykh
=zjvM
-----END PGP SIGNATURE-----

--Signature=_Sun__27_Sep_2009_16_11_37_+0400_R5A6i2cr969czDmR--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090927161137.4becc379.stas>