From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 23 19:31:32 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87B4516A4CE for ; Wed, 23 Jun 2004 19:31:32 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DA5443D31 for ; Wed, 23 Jun 2004 19:31:32 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i5NJUImh086729 for ; Wed, 23 Jun 2004 19:30:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5NJUIHu086728; Wed, 23 Jun 2004 19:30:18 GMT (envelope-from gnats) Resent-Date: Wed, 23 Jun 2004 19:30:18 GMT Resent-Message-Id: <200406231930.i5NJUIHu086728@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Paul Seniura" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AC3D16A4CE; Wed, 23 Jun 2004 19:20:28 +0000 (GMT) Received: from odot.okladot.state.ok.us (odot.okladot.state.ok.us [192.149.244.9]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1782D43D5D; Wed, 23 Jun 2004 19:20:25 +0000 (GMT) (envelope-from root@techpc04.okladot.state.ok.us) Received: from techpc04.okladot.state.ok.us (techpc04.okladot.state.ok.us [199.27.9.37])OAA53158; Wed, 23 Jun 2004 14:19:50 -0500 Received: by techpc04.okladot.state.ok.us (Postfix, from userid 0) id BEB945C5D; Wed, 23 Jun 2004 14:19:50 -0500 (CDT) Message-Id: <20040623191950.BEB945C5D@techpc04.okladot.state.ok.us> Date: Wed, 23 Jun 2004 14:19:50 -0500 (CDT) From: "Paul Seniura" Sender: "Paul Seniura" To: X-Send-Pr-Version: 3.113 cc: trevor@FreeBSD.org Subject: ports/68252: [PATCH] astro/celestia: point to correct full complete source tarball X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Paul Seniura List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2004 19:31:32 -0000 >Number: 68252 >Category: ports >Synopsis: [PATCH] astro/celestia: point to correct full complete source tarball >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jun 23 19:30:18 GMT 2004 >Closed-Date: >Last-Modified: >Originator: "Paul Seniura" >Release: FreeBSD 5.2-CURRENT i386 >Organization: State of Okla. D.O.T. >Environment: System: FreeBSD techpc04.okladot.state.ok.us 5.2-CURRENT FreeBSD 5.2-CURRENT #1: Wed Jun 23 10:30:07 CDT 2004 root@techpc04.okladot.state.ok.us:/usr/obj/src/sys/IBM300SY_4BSD_Os i386 >Description: The astro/celestia port Makefile v1.17 is currently pointing to a known incomplete source tarball. A gmake error will eventually show up during the build: ==snip== gmake[5]: *** No rule to make target `eclipsefinderdlg.cpp', needed by `eclipsefinderdlg.o'. Stop. ==snip== I've documented further compile problems on the ports@ maillist here: >How-To-Repeat: Use the v1.17 Makefile to try building the app. >Fix: Change MASTER_SITES to point to SourceForge's repositories for Celestia. Change distinfo to correlate. ===cut-here=== --- Makefile_orig Mon Jun 21 16:54:31 2004 +++ Makefile Wed Jun 23 13:29:41 2004 @@ -8,8 +8,7 @@ PORTNAME= celestia PORTVERSION= 1.3.1 CATEGORIES= astro -MASTER_SITES= http://fresh.t-systems-sfr.com/unix/src/misc/ -# ${MASTER_SITE_SOURCEFORGE} +MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= celestia MAINTAINER= trevor@FreeBSD.org --- distinfo_orig Mon Jun 14 00:53:39 2004 +++ distinfo Tue Jun 22 15:12:38 2004 @@ -1,2 +1,2 @@ -MD5 (celestia-1.3.1.tar.gz) = 6b5fd597e497b951228c83d4e756a340 -SIZE (celestia-1.2.4.tar.gz) = 10280646 +MD5 (celestia-1.3.1.tar.gz) = fcb73c43f5899f8f7e6d0c619a818a8b +SIZE (celestia-1.3.1.tar.gz) = 13291363 ===cut-here=== The SF sites can be quite slow, but they do have the official tarball, and the updated distinfo matches it. I would like to suggest we not alter the gcc optimization parms that are set in the original project's Makefiles. This app needs every tweak it can get. ;) To illustrate, after applying the above Makefile patch, the patch below will keep the original project's parms intact (I'm striving to test this patch running -Current on a puny pentium2 box): ===cut-here=== --- Makefile Wed Jun 23 13:29:41 2004 +++ Makefile_nohack Wed Jun 23 13:59:17 2004 @@ -57,7 +57,7 @@ pre-patch: @${REINPLACE_CMD} -e \ -'s:-O2::g; s:-Wall::g; s:-ffast-math::g; s:-fexpensive-optimizations::g; s:! /bin/sh:! ${LOCALBASE}/bin/bash:g' \ +'s:! /bin/sh:! ${LOCALBASE}/bin/bash:g' \ ${WRKSRC}/configure pre-install: ===cut-here=== We still have a remaining issue when WITH_KDE=yes is in effect, explained further in the ports@ maillist post mentioned above. I believe other platforms are seeing the KDE bug, too, and will investigate further. For now, tho, we really should change the Makefile & distinfo to point to the correct full source tarball, at the very least, please. :) -- thx, Paul Seniura System Specialist State of Okla. D.O.T. >Release-Note: >Audit-Trail: >Unformatted: