From owner-cvs-src@FreeBSD.ORG  Tue Jun 28 10:11:39 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F2E1D16A41C;
	Tue, 28 Jun 2005 10:11:38 +0000 (GMT) (envelope-from nate@root.org)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C4D1943D53;
	Tue, 28 Jun 2005 10:11:38 +0000 (GMT) (envelope-from nate@root.org)
Received: from [10.0.1.3] (usen-221x253x221x50.ap-US01.usen.ad.jp
	[221.253.221.50])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j5SABXo5002295
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Tue, 28 Jun 2005 03:11:37 -0700
Message-ID: <42C12109.4040908@root.org>
Date: Tue, 28 Jun 2005 03:06:01 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org>
References: <20050628090657.2A18916A420@hub.freebsd.org>
In-Reply-To: <20050628090657.2A18916A420@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2005 10:11:39 -0000

Søren Schmidt wrote:
> sos         2005-06-28 09:06:52 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/ata          ata-queue.c 
>   Log:
>   Zero donecount on auto request sense.
>   
>   PR:             81450
>   Approved by:    re@ (scottl)
>   
>   Revision  Changes    Path
>   1.50      +1 -0      src/sys/dev/ata/ata-queue.c
> 
> 
> Index: src/sys/dev/ata/ata-queue.c
> diff -u src/sys/dev/ata/ata-queue.c:1.49 src/sys/dev/ata/ata-queue.c:1.50
> --- src/sys/dev/ata/ata-queue.c:1.49	Wed May 11 14:36:26 2005
> +++ src/sys/dev/ata/ata-queue.c	Tue Jun 28 09:06:52 2005
> @@ -355,6 +355,7 @@
>  	    bcopy(ccb, request->u.atapi.ccb, 16);
>  	    request->data = (caddr_t)&request->u.atapi.sense_data;
>  	    request->bytecount = sizeof(struct atapi_sense);
> +	    request->donecount = 0;
>  	    request->transfersize = sizeof(struct atapi_sense);
>  	    request->timeout = 5;
>  	    request->flags &= (ATA_R_ATAPI | ATA_R_QUIET);

Since this is a recurring issue, perhaps it makes sense to have a 
ata_init_request() function that prepares a request structure before 
running it.  A similar approach is used in cam.

-- 
Nate