Date: Tue, 28 Jun 2005 03:06:01 -0700 From: Nate Lawson <nate@root.org> To: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c Message-ID: <42C12109.4040908@root.org> In-Reply-To: <20050628090657.2A18916A420@hub.freebsd.org> References: <20050628090657.2A18916A420@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Søren Schmidt wrote: > sos 2005-06-28 09:06:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-queue.c > Log: > Zero donecount on auto request sense. > > PR: 81450 > Approved by: re@ (scottl) > > Revision Changes Path > 1.50 +1 -0 src/sys/dev/ata/ata-queue.c > > > Index: src/sys/dev/ata/ata-queue.c > diff -u src/sys/dev/ata/ata-queue.c:1.49 src/sys/dev/ata/ata-queue.c:1.50 > --- src/sys/dev/ata/ata-queue.c:1.49 Wed May 11 14:36:26 2005 > +++ src/sys/dev/ata/ata-queue.c Tue Jun 28 09:06:52 2005 > @@ -355,6 +355,7 @@ > bcopy(ccb, request->u.atapi.ccb, 16); > request->data = (caddr_t)&request->u.atapi.sense_data; > request->bytecount = sizeof(struct atapi_sense); > + request->donecount = 0; > request->transfersize = sizeof(struct atapi_sense); > request->timeout = 5; > request->flags &= (ATA_R_ATAPI | ATA_R_QUIET); Since this is a recurring issue, perhaps it makes sense to have a ata_init_request() function that prepares a request structure before running it. A similar approach is used in cam. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42C12109.4040908>