From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Mar 20 14:14:15 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AFFAA489
 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 20 Mar 2015 14:14:15 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 95E211A4
 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 20 Mar 2015 14:14:15 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2KEEFD4005973
 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 20 Mar 2015 14:14:15 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 198736] net-mgmt/smokeping init script fails to check pid
 correctly
Date: Fri, 20 Mar 2015 14:14:15 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: vince@unsane.co.uk
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: rodrigo@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 flagtypes.name attachments.created
Message-ID: <bug-198736-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2015 14:14:15 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198736

            Bug ID: 198736
           Summary: net-mgmt/smokeping init script fails to check pid
                    correctly
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: rodrigo@FreeBSD.org
          Reporter: vince@unsane.co.uk
          Assignee: rodrigo@FreeBSD.org
             Flags: maintainer-feedback?(rodrigo@FreeBSD.org)

Created attachment 154574
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154574&action=edit
patch to the smokeping rc.d init file

The init script for smokeping doesn't pass the the interpreter (perl) to
check_pidfile so will claim smokeping isnt running when it is.
adding $command_interpreter as the 3rd argument to check_pidfile fixes this. I
have attached a patch for this

Also there should probably be a sleep 1 or something in smokeping_stop() as a
restart happens too fast and tries to start it again before it dies but I'm
unsure of best practices for that situation so I havent tried to patch this.

-- 
You are receiving this mail because:
You are the assignee for the bug.