From owner-svn-src-head@FreeBSD.ORG Fri Oct 18 17:32:23 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CF2095AF; Fri, 18 Oct 2013 17:32:23 +0000 (UTC) (envelope-from jase@FreeBSD.org) Received: from smtp.btshosting.co.uk (smtp.btshosting.co.uk [178.63.196.250]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5293B2300; Fri, 18 Oct 2013 17:32:23 +0000 (UTC) Received: from [192.168.1.65] (unknown [94.4.78.78]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by svr06-mx.btshosting.co.uk (Postfix) with ESMTPSA id 3D8EB57CD5; Fri, 18 Oct 2013 17:32:15 +0000 (UTC) Message-ID: <52617089.6090708@FreeBSD.org> Date: Fri, 18 Oct 2013 18:31:53 +0100 From: Jase Thew Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Hiroki Sato , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r256498 - head/etc/rc.d References: <201310150454.r9F4snOM001275@svn.freebsd.org> In-Reply-To: <201310150454.r9F4snOM001275@svn.freebsd.org> X-Enigmail-Version: 1.5.2 OpenPGP: id=3F9B9617; url=pool.sks-keyservers.net Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2013 17:32:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0 Content-Type: multipart/mixed; boundary="------------080102050103020609060206" This is a multi-part message in MIME format. --------------080102050103020609060206 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 15/10/2013 05:54, Hiroki Sato wrote: > Author: hrs > Date: Tue Oct 15 04:54:49 2013 > New Revision: 256498 > URL: http://svnweb.freebsd.org/changeset/base/256498 >=20 > Log: > - Fix "ifname|addr" syntax support in jail_{jname}_ip. > - Create /var/run/jail_{jname}.id because ezjail-admin depends on it.= >=20 > Modified: > head/etc/rc.d/jail >=20 Hi Hiroki, This unfortunately breaks ezjail when the address list doesn't use iface prefix syntax. Given this configuration : export jail_poudriere_ip=3D"192.168.1.184,127.0.1.4,::1" results in the following being generated : ip4.addr +=3D "|192.168.1.184/32"; ip4.addr +=3D "|127.0.1.4/32"; ip6.addr +=3D "|::1/64"; The attach patch corrects the issue by suffixing the iface value with "|" only when it has a value. Kind regards, Jase. --=20 Jase Thew jase@FreeBSD.org FreeBSD Ports Committer --------------080102050103020609060206 Content-Type: text/plain; charset=windows-1252; name="jail_iface_prefix_20131018.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="jail_iface_prefix_20131018.patch" LS0tIC9ldGMvcmMuZC9qYWlsLm9yaWcJMjAxMy0xMC0xOCAxNzo0Nzo1OC41MjM4NjkwMzAg KzAxMDAKKysrIC9ldGMvcmMuZC9qYWlsCTIwMTMtMTAtMTggMTg6MTg6MzYuODU5MjIwODAw ICswMTAwCkBAIC0zNjcsMTAgKzM2NywxMCBAQAogCQkjIEFwcGVuZCBhZGRyZXNzIHRvIGxp c3Qgb2YgYWRkcmVzc2VzIGZvciB0aGUgamFpbCBjb21tYW5kLgogCQljYXNlICRfdHlwZSBp bgogCQlpbmV0KQotCQkJZWNobyAiCWlwNC5hZGRyICs9IFwiJHtfaWZhY2V9fCR7X2FkZHJ9 JHtfbWFza31cIjsiCisJCQllY2hvICIJaXA0LmFkZHIgKz0gXCIke19pZmFjZTorJHtfaWZh Y2V9fH0ke19hZGRyfSR7X21hc2t9XCI7IgogCQk7OwogCQlpbmV0NikKLQkJCWVjaG8gIglp cDYuYWRkciArPSBcIiR7X2lmYWNlfXwke19hZGRyfSR7X21hc2t9XCI7IgorCQkJZWNobyAi CWlwNi5hZGRyICs9IFwiJHtfaWZhY2U6KyR7X2lmYWNlfXx9JHtfYWRkcn0ke19tYXNrfVwi OyIKIAkJCW5lZWRfZGFkX3dhaXQ9MQogCQk7OwogCQllc2FjCg== --------------080102050103020609060206-- --Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJ8BAEBCgBmBQJSYXCTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGNzY3ODIxQkE1MTQ4MjNFQ0RGNUM3QkRE NEU2NUM4QkZGMUMzODI5AAoJENTmXIv/HDgpoBMP/i7bR8EaeJF4/frf9AayF5CL Wi3aDNRcN4kDhGikfD7fdSFHRyQlpSXkydOFYHJZG4bXPhdFjHUKoZRSaMyUEdsj vQ0KsiLrjnBYkX6czxHf43PObTM6snZyESU4bplBXSO2HRhOVo9IlG81FEmBdesz Qahf8gvOsmN9b4r/6/stBjaL8uTAQo+A4XydQslUNX3q1fOFn7nDFwg+xsDlNM5Y SMGZ5cLnDb2L5fLtp7tuNqVIiPm4MuxCo/GYow7x31h/F1998Czny7xvydVtzLzM IgDXCO75b9JHBa/n5/BN33eVr8w/zxxUu3c8Dozs4tVM6mfPMbHZI1Rj+y6Mkkw0 QgNkEVSAKg+dyhX7zssYhuUwsboa8zB4pd2xuALDRvNi18/aoKZttaj2jpn3Bamo sOum0Y652kmc+D8/SM30ttAUDk85YodNzz4k1OJxJe2ZcZaz8FQKSpPb4G8TMnz6 YjrhPz6Waig5/fH8jfDSH1UIuP1Ce4dAr3yrnWdo8e++sbF4Y/uKtiDyfHTQIf3M hwf8wCsJBinXkGLwi7znicYOyu2w7COdIyvgGpNFR8iyRcyUtneEV0firYLiMefx 29zO/cZ7tFQItea2j5ePv9PoFS3XrfWDRHJXNwF3ofindT10LLKUNaEPoI0q96+w rBQVMigRZWv2AnP24cfG =fZJZ -----END PGP SIGNATURE----- --Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0--