From owner-cvs-all Wed Dec 19 20:39:48 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.trit.org (bazooka.trit.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 1F6FA37B416; Wed, 19 Dec 2001 20:39:42 -0800 (PST) Received: by bazooka.trit.org (Postfix, from userid 1000) id C1ECB3E2F; Thu, 20 Dec 2001 04:39:41 +0000 (UTC) Received: from bazooka (localhost [127.0.0.1]) by bazooka.trit.org (Postfix) with ESMTP id BDF623C12E; Thu, 20 Dec 2001 04:39:41 +0000 (UTC) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/w w.c In-Reply-To: <200112200437.fBK4bk256772@freefall.freebsd.org>; from dd@FreeBSD.org on "Wed, 19 Dec 2001 20:37:46 -0800 (PST)" Date: Thu, 20 Dec 2001 04:39:36 +0000 From: Dima Dorfman Message-Id: <20011220043941.C1ECB3E2F@bazooka.trit.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dima Dorfman wrote: > dd 2001/12/19 20:37:46 PST > > Modified files: (Branch: RELENG_4) > usr.bin/w w.c > Log: > Change the type of 'l' (in main()) from u_long to in_addr_t like it > should have been all this time. This unbreaks DNS lookups on > platforms where 'long' is not 32 bits (e.g., Alpha) because > _gethostbydnsaddr() (in gethostbydns.c), called via gethostbyaddr(), > will check that the given length corresponds to the length of > addresses in the given family, and fail with EINVAL if it isn't. > > This change does not apply to -CURRENT because the latter uses > realhostname() (which doesn't have this bug) to do its DNS lookups. MFC'in the realhostname() changes (1.48 of w.c) is probably a better idea, but I wanted to fix this before the freeze, and didn't feel comfortable merging 1.48 (mostly because I don't understand parts of it, probably because I'm not familiar with realhostname()). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message