From owner-freebsd-ports Wed Jan 30 17:40: 9 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 10C4537B404 for ; Wed, 30 Jan 2002 17:40:05 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g0V1e4B53755; Wed, 30 Jan 2002 17:40:04 -0800 (PST) (envelope-from gnats) Date: Wed, 30 Jan 2002 17:40:04 -0800 (PST) Message-Id: <200201310140.g0V1e4B53755@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: "Scot W. Hetzel" Subject: Re: ports/34459: Dumping config.log on configure error is unintuitive. Reply-To: "Scot W. Hetzel" Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR ports/34459; it has been noted by GNATS. From: "Scot W. Hetzel" To: "Thomas Hurst" , Cc: Subject: Re: ports/34459: Dumping config.log on configure error is unintuitive. Date: Wed, 30 Jan 2002 19:33:01 -0600 This is a multi-part message in MIME format. ------=_NextPart_000_01C5_01C1A9C4.EE084C90 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit From: "Thomas Hurst" > To: "Scot W. Hetzel" > > bsd.port.mk doesn't dump the contents of the config.log. config.log is > > dumped by the configure script in the work/ directory. > > Um, line 2270: > > ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}; then \ > ${ECHO} "===> Script \"${CONFIGURE_SCRIPT}\" failed: here are the contents of \"${CONFIGURE_LOG}\""; \ > ${CAT} ${CONFIGURE_LOG}; \ > ${ECHO} "(end of \"${CONFIGURE_LOG}\")"; \ > I stand corrected, I have attached a patch that puts a 'if CONFIG_DEBUG.... .. fi' around this. I believe this was added so that bento's logs would have the output of the config.log file in them. Bento's scripts would need to be changed to add a -DCONFIG_DEBUG when building packages. Scot ------=_NextPart_000_01C5_01C1A9C4.EE084C90 Content-Type: application/octet-stream; name="bsd.port.mk.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="bsd.port.mk.diff" Index: bsd.port.mk=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v=0A= retrieving revision 1.397=0A= diff -u -r1.397 bsd.port.mk=0A= --- bsd.port.mk 24 Jan 2002 01:15:03 -0000 1.397=0A= +++ bsd.port.mk 31 Jan 2002 01:18:28 -0000=0A= @@ -513,6 +513,7 @@=0A= # to turn them off (default: ${ECHO}).=0A= # PATCH_DEBUG - If set, print out more information about the patches as=0A= # it attempts to apply them.=0A= +# CONFIG_DEBUG - If set, print out more information about the configure = process.=0A= # PKG_DBDIR - Where package installation is recorded (default: = /var/db/pkg)=0A= # NO_PKG_REGISTER - Don't register a port installation as a package.=0A= # FORCE_PKG_REGISTER - If set, it will overwrite any existing package=0A= @@ -1112,6 +1112,12 @@=0A= PATCH_DIST_ARGS+=3D -C=0A= .endif=0A= =0A= +.if defined(CONFIG_DEBUG)=0A= +CONFIG_DEBUG_TMP=3D yes=0A= +.else=0A= +CONFIG_DEBUG_TMP=3D no=0A= +.endif=0A= +=0A= .if exists(/bin/tar)=0A= TAR?=3D /bin/tar=0A= .else=0A= @@ -2204,9 +2204,13 @@=0A= INSTALL_PROGRAM=3D"${INSTALL_PROGRAM}" \=0A= INSTALL_SCRIPT=3D"${INSTALL_SCRIPT}" \=0A= ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}; then \=0A= - ${ECHO} "=3D=3D=3D> Script \"${CONFIGURE_SCRIPT}\" failed: here are = the contents of \"${CONFIGURE_LOG}\""; \=0A= - ${CAT} ${CONFIGURE_LOG}; \=0A= - ${ECHO} "(end of \"${CONFIGURE_LOG}\")"; \=0A= + if [ ${CONFIG_DEBUG_TMP =3D yes ]; then \=0A= + ${ECHO} "=3D=3D=3D> Script \"${CONFIGURE_SCRIPT}\" failed: here = are the contents of \"${CONFIGURE_LOG}\""; \=0A= + ${CAT} ${CONFIGURE_LOG}; \=0A= + ${ECHO} "(end of \"${CONFIGURE_LOG}\")"; \=0A= + else \=0A= + ${ECHO} "=3D=3D=3D> Script \"${CONFIGURE_SCRIPT}\" failed: review = ${CONFIGURE_WRKSRC}/${CONFIGURE_LOG} for problem" ; \=0A= + fi ; \=0A= ${FALSE}; \=0A= fi)=0A= .endif=0A= ------=_NextPart_000_01C5_01C1A9C4.EE084C90-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message