From owner-svn-src-all@FreeBSD.ORG  Wed Oct  8 09:50:59 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7545AC99;
 Wed,  8 Oct 2014 09:50:59 +0000 (UTC)
Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35])
 by mx1.freebsd.org (Postfix) with ESMTP id 394916B9;
 Wed,  8 Oct 2014 09:50:58 +0000 (UTC)
Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534)
 id 6449420E70953; Wed,  8 Oct 2014 09:50:51 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
 smtp1.multiplay.co.uk
X-Spam-Level: *
X-Spam-Status: No, score=1.6 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX,
 FSL_HELO_NON_FQDN_1,RDNS_DYNAMIC,STOX_REPLY_TYPE autolearn=no version=3.3.1
Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170])
 by smtp1.multiplay.co.uk (Postfix) with ESMTP id BEBDA20E70951;
 Wed,  8 Oct 2014 09:50:49 +0000 (UTC)
Message-ID: <81F46B899A5843B7B0D07649108D5A97@multiplay.co.uk>
From: "Steven Hartland" <smh@freebsd.org>
To: "Kashyap D Desai" <kadesai@FreeBSD.org>, <src-committers@freebsd.org>,
 <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
References: <201410080930.s989Uat9073960@svn.freebsd.org>
Subject: Re: svn commit: r272738 - in head/sys: dev/mrsas modules/mrsas
 modules/mrsas/mrsas_linux
Date: Wed, 8 Oct 2014 10:50:47 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Oct 2014 09:50:59 -0000

I thought it was convension to avoid using $FreeBSD$ in code comments instead use the __FBSDID e.g. 

#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>

Could anyone confirm?

    Regards
    Steve

----- Original Message ----- 
From: "Kashyap D Desai" <kadesai@FreeBSD.org>
To: <src-committers@freebsd.org>; <svn-src-all@freebsd.org>; <svn-src-head@freebsd.org>
Sent: Wednesday, October 08, 2014 10:30 AM
Subject: svn commit: r272738 - in head/sys: dev/mrsas modules/mrsas modules/mrsas/mrsas_linux


> Author: kadesai
> Date: Wed Oct  8 09:30:35 2014
> New Revision: 272738
> URL: https://svnweb.freebsd.org/changeset/base/272738
> 
> Log:
>  Fix the minor svn add issue. $FreeBSD$ expands at the time of
>  snv add, so I have added $FreeBSD$ as comment.
>  
>  This commit is contininous of last mrsas commit, so that compilation
>  does not break.
>  
>  Obtained from: AVAGO Technologies
>  MFC after: 2 weeks
> 
> Modified:
>  head/sys/dev/mrsas/mrsas_linux.c
>  head/sys/modules/mrsas/Makefile
>  head/sys/modules/mrsas/mrsas_linux/Makefile
> 
> Modified: head/sys/dev/mrsas/mrsas_linux.c
> ==============================================================================
> --- head/sys/dev/mrsas/mrsas_linux.c Wed Oct  8 09:19:35 2014 (r272737)
> +++ head/sys/dev/mrsas/mrsas_linux.c Wed Oct  8 09:30:35 2014 (r272738)
> @@ -39,10 +39,10 @@
>  * Mail to: LSI Corporation, 1621 Barber Lane, Milpitas, CA 95035
>  *    ATTN: MegaRaid FreeBSD
>  *
> + * $FreeBSD$
>  */
> 
> #include <sys/cdefs.h>
> -<!-- $FreeBSD$ -->
> 
> #include <sys/param.h>
> #include <sys/systm.h>
> 
> Modified: head/sys/modules/mrsas/Makefile
> ==============================================================================
> --- head/sys/modules/mrsas/Makefile Wed Oct  8 09:19:35 2014 (r272737)
> +++ head/sys/modules/mrsas/Makefile Wed Oct  8 09:30:35 2014 (r272738)
> @@ -1,5 +1,5 @@
> # Makefile for mrsas driver
> -<!-- $FreeBSD$ -->
> +# $FreeBSD$
> 
> KMOD=mrsas
> .PATH: ${.CURDIR}/../../dev/${KMOD}
> 
> Modified: head/sys/modules/mrsas/mrsas_linux/Makefile
> ==============================================================================
> --- head/sys/modules/mrsas/mrsas_linux/Makefile Wed Oct  8 09:19:35 2014 (r272737)
> +++ head/sys/modules/mrsas/mrsas_linux/Makefile Wed Oct  8 09:30:35 2014 (r272738)
> @@ -1,5 +1,5 @@
> # Makefile for mrsas driver
> -<!-- $FreeBSD$ -->
> +# $FreeBSD$
> 
> .PATH: ${.CURDIR}/../../../dev/mrsas
> 
> 
>