From owner-svn-ports-head@FreeBSD.ORG  Wed Dec  5 02:00:56 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 34F7AEE0; Wed,  5 Dec 2012 02:00:56 +0000 (UTC)
Date: Wed, 5 Dec 2012 02:00:56 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Subject: Re: svn commit: r308295 - head/databases/adodb5
Message-ID: <20121205020056.GB46964@FreeBSD.org>
References: <201212050117.qB51H1vJ024041@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201212050117.qB51H1vJ024041@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2012 02:00:56 -0000

On Wed, Dec 05, 2012 at 01:17:01AM +0000, Jason Helfman wrote:
> New Revision: 308295
> URL: http://svnweb.freebsd.org/changeset/ports/308295
> 
> @@ -1,15 +1,12 @@
> -# New ports collection makefile for: adodb5
> -# Date created:		25 Dec 2007
> -# Whom:			mm@FreeBSD.org
> +# Created by: mm@FreeBSD.org
>  #
>  # $FreeBSD$
> -#

Header is still incorrect.

> -OPTIONS=	TESTS "Install tests" off
> +OPTIONS_DEFINE=	TESTS
> +TESTS_DESC=	"Install tests"

FOO_DESC should not be quoted.  There are other minor style bugs remain in
the Makefile.

./danfe