From owner-p4-projects@FreeBSD.ORG Sun Feb 22 02:36:42 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 823BC1065672; Sun, 22 Feb 2009 02:36:42 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41805106564A; Sun, 22 Feb 2009 02:36:42 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id EC3DA8FC14; Sun, 22 Feb 2009 02:36:41 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 749AE14D8655; Sun, 22 Feb 2009 03:21:34 +0100 (CET) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.mypc.hu ([127.0.0.1]) by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ne1ZHy2wIfWo; Sun, 22 Feb 2009 03:21:33 +0100 (CET) Received: from [192.168.1.105] (catv-80-98-231-64.catv.broadband.hu [80.98.231.64]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 99FA414D8651; Sun, 22 Feb 2009 03:21:33 +0100 (CET) Message-ID: <49A0B6AC.9000303@FreeBSD.org> Date: Sun, 22 Feb 2009 03:21:32 +0100 From: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Sam Leffler References: <200902220119.n1M1JljJ020105@repoman.freebsd.org> <49A0B129.6030308@freebsd.org> In-Reply-To: <49A0B129.6030308@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: Perforce Change Reviews , "David E. O'Brien" Subject: Re: PERFORCE change 158046 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2009 02:36:43 -0000 Sam Leffler escribió: > Gabor Kovesdan wrote: >> http://perforce.freebsd.org/chv.cgi?CH=158046 >> >> Change 158046 by gabor@gabor_server on 2009/02/22 01:19:13 >> >> - Add support for GREP_OPTIONS >> >> > > How many apps take options via the environment? Not sure I like > this--I can imagine very confusing situations caused by > unseen/unnoticed environment variables. You're right, it might by dangerous if it is misused, but GNU grep uses it so we should support this to maintain compatibility. And in some cases, it can be really useful, imagine that you always want to colorize the output, you can just set GREP_OPTIONS="--color". I'd say that those who don't like it, can just ignore this and don't use it all, while others who have been using it can keep using it, that's fair enough. (CC'd obrien@ as he was the proposer, who reminded me of this missing feature.) -- Gabor Kovesdan EMAIL: gabor@FreeBSD.org WWW: http://www.kovesdan.org