Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Oct 2006 15:58:07 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Paolo Pisati <piso@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 107815 for review
Message-ID:  <200610131558.07530.jhb@freebsd.org>
In-Reply-To: <200610131200.k9DC0ajd097822@repoman.freebsd.org>
References:  <200610131200.k9DC0ajd097822@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 13 October 2006 08:00, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=107815
> 
> Change 107815 by piso@piso_newluxor on 2006/10/13 12:00:35
> 
> 	Fixes compilation of GENERIC on amd64.

It would be better to fix the functions to return an appropriate value.

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/amd64/isa/clock.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/amd64/isa/clock.c#6 (text+ko) ====
> 
> @@ -758,7 +758,7 @@
>  	 * timecounter to user a simpler algorithm.
>  	 */
>  	if (!using_lapic_timer) {
> -		intr_add_handler("clk", 0, clkintr, NULL, NULL,
> +		intr_add_handler("clk", 0, (driver_filter_t *)clkintr, NULL, NULL,
>  		    INTR_TYPE_CLK, NULL);
>  		i8254_intsrc = intr_lookup_source(0);
>  		if (i8254_intsrc != NULL)
> @@ -792,7 +792,7 @@
>  
>  		/* Enable periodic interrupts from the RTC. */
>  		rtc_statusb |= RTCSB_PINTR;
> -		intr_add_handler("rtc", 8, rtcintr, NULL, NULL,
> +		intr_add_handler("rtc", 8, (driver_filter_t *)rtcintr, NULL, NULL,
>  		    INTR_TYPE_CLK, NULL);
>  
>  		writertc(RTC_STATUSB, rtc_statusb);
> 

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610131558.07530.jhb>