From owner-svn-src-all@FreeBSD.ORG  Wed May  4 11:29:45 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4B5D0106566C;
	Wed,  4 May 2011 11:29:45 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
	by mx1.freebsd.org (Postfix) with ESMTP id C86318FC0C;
	Wed,  4 May 2011 11:29:44 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.sbone.de (Postfix) with ESMTPS id 5E97F25D3860;
	Wed,  4 May 2011 11:29:43 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
	[IPv6:fde9:577b:c1a9:31::2013:2742])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPS id 5CDC9159EA70;
	Wed,  4 May 2011 11:29:42 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
	by content-filter.sbone.de (content-filter.sbone.de
	[fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
	with ESMTP id l6o5e4Asnl+3; Wed,  4 May 2011 11:29:41 +0000 (UTC)
Received: from orange-en1.sbone.de (orange-en1.sbone.de
	[IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by mail.sbone.de (Postfix) with ESMTPSA id 3C3C5159EA6F;
	Wed,  4 May 2011 11:29:41 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
In-Reply-To: <20110504111759.GK2183@hoeg.nl>
Date: Wed, 4 May 2011 11:29:40 +0000
Content-Transfer-Encoding: quoted-printable
Message-Id: <BB7203C3-39B1-4D31-B914-533186534B9E@FreeBSD.org>
References: <201105040252.p442qfI4027516@svn.freebsd.org>
	<20110504111759.GK2183@hoeg.nl>
To: Ed Schouten <ed@80386.nl>
X-Mailer: Apple Mail (2.1084)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Subject: Re: svn commit: r221419 - head/release
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2011 11:29:45 -0000


On May 4, 2011, at 11:17 AM, Ed Schouten wrote:

> Hi Nathan,
>=20
> * Nathan Whitehorn <nwhitehorn@FreeBSD.org>, 20110504 04:52:
>> chroot $2 /bin/sh -c "cd /usr/src && make $MAKE_FLAGS buildworld =
buildkernel" || exit 1
>> +chroot $2 /bin/sh -c "cd /usr/src/release && make obj" || exit 1
>> chroot $2 /bin/sh -c "cd /usr/src/release && make release" || exit 1
>> chroot $2 /bin/sh -c "cd /usr/src/release && make install DESTDIR=3D/R"=
 || exit 1
>=20
> Wouldn't it be a bit more elegant to do something like this?
>=20
> 	chroot $2 make -C /usr/src/release obj
>=20
> Also, if you enable set -e, the script terminates upon error.

Which is as bad as well as it needs to cleanup devfs mounts etc. in case =
of
errors.  I am trying to get one finished and will post the results as =
well as
possible error cases I have hit so we can generally improve the script =
and
make it more robust.  So far I am on build #4 ;-)

/bz

--=20
Bjoern A. Zeeb                                 You have to have visions!
         Stop bit received. Insert coin for new address family.