From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jul 12 11:30:02 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9946C958 for ; Fri, 12 Jul 2013 11:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 7B8FB1E53 for ; Fri, 12 Jul 2013 11:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r6CBU20p083078 for ; Fri, 12 Jul 2013 11:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r6CBU2oS083077; Fri, 12 Jul 2013 11:30:02 GMT (envelope-from gnats) Resent-Date: Fri, 12 Jul 2013 11:30:02 GMT Resent-Message-Id: <201307121130.r6CBU2oS083077@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexey Markov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DAEC67EE for ; Fri, 12 Jul 2013 11:25:18 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id CC2381E25 for ; Fri, 12 Jul 2013 11:25:18 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r6CBPIVO050621 for ; Fri, 12 Jul 2013 11:25:18 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r6CBPIwX050620; Fri, 12 Jul 2013 11:25:18 GMT (envelope-from nobody) Message-Id: <201307121125.r6CBPIwX050620@oldred.freebsd.org> Date: Fri, 12 Jul 2013 11:25:18 GMT From: Alexey Markov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/180490: net/svnup: insufficient check of $FreeBSD$ lines X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jul 2013 11:30:02 -0000 >Number: 180490 >Category: ports >Synopsis: net/svnup: insufficient check of $FreeBSD$ lines >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jul 12 11:30:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Alexey Markov >Release: 8.3-RELEASE-p7 >Organization: JSC Complitex >Environment: FreeBSD host.redrat.ru 8.3-RELEASE-p7 FreeBSD 8.3-RELEASE-p7 #0: Thu Apr 4 14:15:05 MSK 2013 redrat@host.redrat.ru:/arc/obj/arc/src/sys/HOST amd64 >Description: Fore some reason svnup doesn't check $FreeBSD$ line for actual data in it, thus after source tree updating some files has this line truncated, without actual data. >How-To-Repeat: Get FreeBSD 8.4-RELEASE distributive media and extract source tree from it to some folder (e.g. /new/1). Run svnup upon this folder: svnup release -l /new/1 Fetch source tree to another, empty folder: svnup release -l /new/2 Compare files in these folders: Files /new/1/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 and /new/2/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 differ Files /new/1/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c and /new/2/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c differ Files /new/1/sys/mips/rmi/xlr_boot1_console.c and /new/2/sys/mips/rmi/xlr_boot1_console.c differ Files /new/1/tools/regression/bin/sh/builtins/break3.0 and /new/2/tools/regression/bin/sh/builtins/break3.0 differ #diff /new/1/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 /new/2/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 22c22 < .\" $FreeBSD$ --- > .\" $FreeBSD: release/8.4.0/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1 235571 2012-05-18 00:02:11Z gjb $ >Fix: I think that svnup have to check $FreeBSD$ line for correct format and change it to match the line in the repository. >Release-Note: >Audit-Trail: >Unformatted: