From owner-freebsd-ports@FreeBSD.ORG Mon Jan 17 10:14:32 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5263816A4CE for ; Mon, 17 Jan 2005 10:14:32 +0000 (GMT) Received: from lakermmtao04.cox.net (lakermmtao04.cox.net [68.230.240.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id A721443D53 for ; Mon, 17 Jan 2005 10:14:31 +0000 (GMT) (envelope-from conrads@cox.net) Received: from dolphin.local.net ([68.14.122.164]) by lakermmtao04.cox.net (InterMail vM.6.01.04.00 201-2131-117-20041022) with ESMTP <20050117101427.CQJD22354.lakermmtao04.cox.net@dolphin.local.net>; Mon, 17 Jan 2005 05:14:27 -0500 Received: from dolphin.local.net (localhost.local.net [127.0.0.1]) by dolphin.local.net (8.13.1/8.13.1) with ESMTP id j0HAENBD012734; Mon, 17 Jan 2005 04:14:23 -0600 (CST) (envelope-from conrads@cox.net) Date: Mon, 17 Jan 2005 04:14:18 -0600 From: "Conrad J. Sabatier" To: "Conrad J. Sabatier" Message-ID: <20050117041418.4eb127cf@dolphin.local.net> In-Reply-To: <20050117023232.56447133@dolphin.local.net> References: <200412231651.52690.h@erathia.be> <20041226132723.GI1435@k7.mavetju> <200412261512.50849.h@erathia.be> <200412261239.06078.krinklyfig@spymac.com> <20050117021229.1e8b42ee@dolphin.local.net> <20050117023232.56447133@dolphin.local.net> X-Mailer: Sylpheed-Claws 0.9.13 (GTK+ 1.2.10; amd64-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: Aaron Myles Landwehr cc: Joshua Tinnin cc: Robert Uhl cc: Edwin Groothuis cc: freebsd-ports@freebsd.org cc: h Subject: Re: broken port: gnuchess X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2005 10:14:32 -0000 OK, I figured out what the problem was. The "DISTFILES+=" line was not behaving as one would expect. Rather than appending to the default (implicitly declared) DISTFILES set of "gnuchess-5.0.7.tar.gz", it winds up being the *only* member of the DISTFILES set (have we stumbled across a bug in the ports build system, perhaps?). Running 'portlint -v' reveals this to be true. Edwin, do you want me to just send you a diff against the Makefile, or against the whole port? Actually, it's really such a very minor fix, perhaps you could just do it yourself by hand and go ahead and do a quick commit on it. All it involves is adding, just after the "MASTER_SITE_SUBDIR= chess" line, an explicit: DISTFILES= ${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} This allows the later DISTFILES+= to work as expected (this sure seems like a bug somewhere in /usr/ports/Mk to me). Portlint will whine about using DISTFILES= for only a single file (apparently, it completely overlooks the later DISTFILES+= in deciding this), and it also wants the EXTRACT_ONLY= line pushed up earlier, but logically, I think it belongs right where you moved it to. So, portlint be damned! I think we know better. :-) Oh, and portlint also seemed to think that the scripts dir was not in CVS! Very odd! Just let me know how you want to handle this, Edwin. I'd appreciate it if you'd just go ahead and do a quick fix on this. Thanks, and once again, sorry for taking so long to getting around to fixing this. Conrad -- Conrad J. Sabatier -- "In Unix veritas"