From owner-cvs-all Tue Jan 21 18:21:57 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3651137B401; Tue, 21 Jan 2003 18:21:56 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC4E443F18; Tue, 21 Jan 2003 18:21:55 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 91FBDAE2D9; Tue, 21 Jan 2003 18:21:55 -0800 (PST) Date: Tue, 21 Jan 2003 18:21:55 -0800 From: Alfred Perlstein To: Peter Wemm Cc: Jeff Roberson , Bosko Milekic , Nate Lawson , Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/osf1 imgact_osf1.c osf1_misc.c src/sys/cam cam_periph.c cam_sim.c cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi Message-ID: <20030122022155.GO42333@elvis.mu.org> References: <20030121205616.I46974-100000@mail.chesapeake.net> <20030122020826.87F7F2A7EA@canning.wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030122020826.87F7F2A7EA@canning.wemm.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Peter Wemm [030121 18:08] wrote: > Jeff Roberson wrote: > > > > Ok, I looked at the diff/commit a little closer. What I suggest we do is > > this: > > > > Leave M_WAITOK defined. This way we keep the ABI and API the same for > > 5.0. In 6.0 go ahead and remove it. New code should not use this 'flag'. > > Slight variation. Can we make M_WAITOK and the other not-a-flag flags > ifdef'ed under KLD_MODULE or something? That way we can reduce some of the > avoidable pain with 3rd party external modules, and still get to be sure > that our own house (src/sys/*) is kept clean. That's fine with me, I wish there was a way to do #ifused M_WAITOK #warning ... though. :) I agree with your follow-up that people should be able to suck it up with thier deltas though and deal with it without much of a problem. -- -Alfred Perlstein [alfred@freebsd.org] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message